Docker refactoring #522
Open
Docker refactoring #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mec-iS
force-pushed
the
docker-refactoring
branch
from
45fe7c5 to
53ab0b1
Compare
|
Maybe this example could help: https://gitmemory.com/issue/sdispater/poetry/366/488720509 |
king-11
reviewed
Jan 14, 2021
| - "3.7" | ||
| - "3.7-dev" # 3.7 development branch | ||
| install: | ||
| - pip install -r requirements.txt --no-cache | ||
| - pip install poetry |
There was a problem hiding this comment.
From the poetry docs, the recommended method to install poetry is not to use pip rather their own script
|
@Mec-iS I can work on this if you aren't |
sorry for the late reply. You don't need to ask for permission. You can just follow the Github Flow and open a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement Poetry for Docker and get rid of
requirements.txt. This will avoid dependencies conflicts from now on thanks to the lock file.I am not 100% sure the
Dockerfileis done correctly, please trydocker-compose up --buildlocally and provide suggestions about how to make this working/safer/more stable.