Restore backwards compatibility for LightRAG's ainsert method #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et a None default value
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the split_by_character parameter optional in ainsert method to maintain backwards compatibility with existing code.
Details:
The ainsert method in LightRAG class was recently modified to include a new split_by_character parameter
This change broke backwards compatibility for code using the previous method signature
Fixed by making split_by_character parameter optional with a default value of None
Impact:
Restores compatibility with existing code using the old method signature
Maintains new functionality for users who want to use character splitting
No breaking changes