fix(ConfigMenu): For numer type, use the step not the index

HHogg · Dec 26, 2023 · 7593263 · 7593263
1 parent 75082f6
commit 7593263
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/workspaces/package/src/ConfigMenu/ConfigMenu.tsx b/workspaces/package/src/ConfigMenu/ConfigMenu.tsx
@@ -141,6 +141,16 @@ const toggleValueInArray = (array: string[], value: string) => {
   }
 };
 
+const getSteps = (min: number, max: number, step: number) => {
+  const steps = [];
+
+  for (let i = min; i <= max; i += step) {
+    steps.push(i);
+  }
+
+  return steps;
+};
+
 const __root = '__root';
 
 export const ConfigMenu = ({
@@ -245,19 +255,15 @@ export const ConfigMenu = ({
           )}
 
           {isNumber(activeEntry) &&
-            Array.from({
-              length: Math.floor(
-                (activeEntry.max - activeEntry.min) / activeEntry.step
-              ),
-            }).map(
-              (_, i) =>
+            getSteps(activeEntry.min, activeEntry.max, activeEntry.step).map(
+              (v) =>
                 isNumber(activeEntry) && (
                   <MenuItemCheckBox
-                    checked={activeEntry.value === i}
-                    key={i}
-                    onClick={createUpdateHandler(activeEntry, i)}
+                    checked={activeEntry.value === v}
+                    key={v}
+                    onClick={createUpdateHandler(activeEntry, v)}
                   >
-                    {activeEntry.formatter?.(i) ?? i}
+                    {activeEntry.formatter?.(v) ?? v}
                   </MenuItemCheckBox>
                 )
             )}