[Issue #3788] Include protocol when defining CDN_URL #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
approved these changes
Feb 6, 2025
DavidDudas-Intuitial
pushed a commit
that referenced
this pull request
Feb 7, 2025
## Summary Fixes #3788 ### Time to review: __1 mins__ ## Changes proposed The links in the API need to include the protocol, at the terraform level we transition from domain name to URL without adding the protocol, so injecting it there seems like the most logical place. ## Context for reviewers URLs were missing a protocol, so the browser interprets them as a relative URL in the FE and other API consumers would have needed to know to add an https://
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3788
Time to review: 1 mins
Changes proposed
The links in the API need to include the protocol, at the terraform level we transition from domain name to URL without adding the protocol, so injecting it there seems like the most logical place.
Context for reviewers
URLs were missing a protocol, so the browser interprets them as a relative URL in the FE and other API consumers would have needed to know to add an https://