[Issue #3696] Update get agencies endpoint to remove extra queries #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehgrantsgov
approved these changes
Jan 31, 2025
DavidDudas-Intuitial
pushed a commit
that referenced
this pull request
Feb 7, 2025
…3733) ## Summary Fixes #3696 ### Time to review: __5 mins__ ## Changes proposed Cleanup the way we setup get agencies queries to remove extra/unused logic ## Context for reviewers It looks like two separate queries were setup to do the same thing, but only one is used, trim out the extra one that might actually cause issues because it's setting the top level agency in its loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3696
Time to review: 5 mins
Changes proposed
Cleanup the way we setup get agencies queries to remove extra/unused logic
Context for reviewers
It looks like two separate queries were setup to do the same thing, but only one is used, trim out the extra one that might actually cause issues because it's setting the top level agency in its loop.