[Issue #3730] Fix parsing issueType
bug
#3731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the type in the
IssueType
pydantic model that was causingissueType
to be parsed incorrectly.Fixes #3730
Time to review: 5 mins
Changes proposed
IssueType
field alias (it was incorrectly aliased as"type"
instead of"issueType"
)Context for reviewers
make gh-data-export
to export the data from GitHubnull
value for issue type:jq '[.[] | select(.issue_type == null)] | length' data/delivery-data.json
data/delivery-data.json
where"issue_type"
isnull
each issue that you check, should be missing a "Type" in GitHub (see screenshot below)Additional information
A major goal for Sprint 2.3 will be to set up some automated data quality checks in both Metabase and the ETL pipeline to prevent or at least catch similar regressions earlier.