Skip to content

Commit

Permalink
various small fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
coilysiren committed Jan 30, 2025
1 parent 5afe3c9 commit 6715cec
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 18 deletions.
2 changes: 0 additions & 2 deletions infra/analytics/app-config/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ locals {

has_incident_management_service = false

feature_flags = ["foo", "bar"]

environment_configs = {
dev = module.dev_config
staging = module.staging_config
Expand Down
4 changes: 0 additions & 4 deletions infra/analytics/app-config/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ output "environments" {
value = local.environments
}

output "feature_flags" {
value = local.feature_flags
}

output "has_database" {
value = local.has_database
}
Expand Down
1 change: 1 addition & 0 deletions infra/analytics/database/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ data "aws_security_groups" "aws_services" {
module "database" {
source = "../../modules/database"
name = "${local.prefix}${local.database_config.cluster_name}"
access_policy_name = "${local.prefix}${local.database_config.access_policy_name}"
app_access_policy_name = "${local.prefix}${local.database_config.app_access_policy_name}"
migrator_access_policy_name = "${local.prefix}${local.database_config.migrator_access_policy_name}"
# The following are not AWS infra resources and therefore do not need to be
Expand Down
6 changes: 5 additions & 1 deletion infra/api/app-config/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ locals {
has_database = true
has_incident_management_service = false

feature_flags = ["foo", "bar"]
# Whether or not the application depends on external non-AWS services.
# If enabled, the networks associated with this application's environments
# will have NAT gateways, which allows the service in the private subnet to
# make calls to the internet.
has_external_non_aws_service = true

environment_configs = {
dev = module.dev_config
Expand Down
4 changes: 0 additions & 4 deletions infra/api/app-config/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ output "environments" {
value = local.environments
}

output "feature_flags" {
value = local.feature_flags
}

output "has_database" {
value = local.has_database
}
Expand Down
4 changes: 1 addition & 3 deletions infra/frontend/app-config/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@ locals {
# If enabled, the networks associated with this application's environments
# will have NAT gateways, which allows the service in the private subnet to
# make calls to the internet.
has_external_non_aws_service = false
has_external_non_aws_service = true

has_incident_management_service = false
enable_autoscaling = true
hostname = "0.0.0.0"

feature_flags = ["foo", "bar"]

environment_configs = {
dev = module.dev_config
staging = module.staging_config
Expand Down
4 changes: 0 additions & 4 deletions infra/frontend/app-config/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ output "environments" {
value = local.environments
}

output "feature_flags" {
value = local.feature_flags
}

output "has_database" {
value = local.has_database
}
Expand Down

0 comments on commit 6715cec

Please sign in to comment.