Refactor HEDM calibration to use new workflow #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the HEDM calibration to use the new calibration workflow we have been using for powder and Laue. It includes the use of lmfit for boundary constraints, support for relative constraints between detectors (including for subpanels), and many highly desirable features such as undo/redo. This refactoring completely eliminates the need for the old calibration workflow, and thus a lot of old code is being removed as well, including the ability to set refinements in the instrument tree view and the refinements editor. Although this still needs to be further tested, it is overall a major improvement for HEDM calibration. Depends on: HEXRD/hexrd#779 Signed-off-by: Patrick Avery <[email protected]>
|
Since this is somewhat urgent, we'll get it in and perform any necessary cleanup later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the HEDM calibration to use the new calibration workflow we have been using for powder and Laue. It includes the use of lmfit for boundary constraints, support for relative constraints between detectors (including for subpanels), and many highly desirable features such as undo/redo.
This refactoring completely eliminates the need for the old calibration workflow, and thus a lot of old code is being removed as well, including the ability to set refinements in the instrument tree view and the refinements editor.
Although this still needs to be further tested, it is overall a major improvement for HEDM calibration.
Depends on: HEXRD/hexrd#779