Ignore old view generation errors #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View generations occur asynchronously in a background thread. Sometimes, they can take a long time to perform. If a user modifies settings while the view is being generated (such as reducing the resolution to speed up the view generation time), the old view would produce errors when it finished because the settings changed unexpectedly. Stopping threads is difficult, and usually requires adding checks within the code so that the thread can check if it should exit early. Rather than doing that, which could be time-consuming, require many code modifications, and may not even be effective (if something causes the bottleneck to be somewhere that the early exit flag cannot be checked easily), we now just check when the old view generation is complete (either when it errors out or finishes successfully) if a new view began generating while it was running. If so, it now cleanly ignores the error or does not perform the update (in case of success). Signed-off-by: Patrick Avery <[email protected]>
saransh13
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View generations occur asynchronously in a background thread. Sometimes, they can take a long time to perform. If a user modifies settings while the view is being generated (such as reducing the resolution to speed up the view generation time), the old view would produce errors when it finished because the settings changed unexpectedly.
Stopping threads is difficult, and usually requires adding checks within the code so that the thread can check if it should exit early. Rather than doing that, which could be time-consuming, require many code modifications, and may not even be effective (if something causes the bottleneck to be somewhere that the early exit flag cannot be checked easily), we now just check when the old view generation is complete (either when it errors out or finishes successfully) if a new view began generating while it was running. If so, it now cleanly ignores the error or does not perform the update (in case of success).