Code

First pass at new MaskManager class#1622

Code

Merged

bnmajor merged 27 commits intoHEXRD:masterHEXRD/hexrdgui:masterfrom bnmajor:simplify-mask-managementbnmajor/hexrdgui:simplify-mask-managementCopy head branch name to clipboardJan 22, 2024

+713-585

Commits

Commits on Jan 8, 2024

• First pass at new MaskManager class

  Show description for 6e0360b
  bnmajor

  committed
  6e0360b

  Copy full SHA for 6e0360b

• Fix up conversion function for old mask files

  Show description for 08448c0
  bnmajor

  committed
  08448c0

  Copy full SHA for 08448c0

• Use attributes rather than properties for now

  Show description for bf80a41
  bnmajor

  committed
  bf80a41

  Copy full SHA for bf80a41

• Move masking files to masking directory

  Show description for 1aa65ed
  bnmajor

  committed
  1aa65ed

  Copy full SHA for 1aa65ed

• Move logic from MaskManagerDialog to MaskManager

  Show description for 80fb656
  bnmajor

  committed
  80fb656

  Copy full SHA for 80fb656

• Finish building the MaskManager and Mask classes

  Show description for 21b8e6c
  bnmajor

  committed
  21b8e6c

  Copy full SHA for 21b8e6c

• Use MaskManager class instead of HexrdConfig dicts/lists

  Show description for b5939b3
  bnmajor

  committed
  b5939b3

  Copy full SHA for b5939b3

• Move mask signals to MaskManager

  Show description for b6c51a0
  bnmajor

  committed
  b6c51a0

  Copy full SHA for b6c51a0

• Move masking functions to MaskManager class

  Show description for d7bedc0
  bnmajor

  committed
  d7bedc0

  Copy full SHA for d7bedc0

• Remove debug statement

  Show description for 0d0191a
  bnmajor

  committed
  0d0191a

  Copy full SHA for 0d0191a

• Fix import/export of overlay masks

  Show description for c3fbe46
  bnmajor

  committed
  c3fbe46

  Copy full SHA for c3fbe46

• PEP8 formatting fixes

  Show description for b399a73
  bnmajor

  committed
  b399a73

  Copy full SHA for b399a73

• Make deserialize a class method

  Show description for dc355b3
  bnmajor

  committed
  dc355b3

  Copy full SHA for dc355b3

• Keep image dict management in HexrdConfig

  Show description for d7394a3
  bnmajor

  committed
  d7394a3

  Copy full SHA for d7394a3

• Simplify mask state conversion logic

  Show description for 82e595a
  bnmajor

  committed
  82e595a

  Copy full SHA for 82e595a

• Remove unused signal

  Show description for 1894b4e
  bnmajor

  committed
  1894b4e

  Copy full SHA for 1894b4e

• Convert get_data/set_data functions to data property/setter

  Show description for 888783e
  bnmajor

  committed
  888783e

  Copy full SHA for 888783e

• Rename for clarity: setup_table -> update_table

  Show description for 6fc846a
  bnmajor

  committed
  6fc846a

  Copy full SHA for 6fc846a

• Do not keep old mask name as attribute

  Show description for 8796612
  bnmajor

  committed
  8796612

  Copy full SHA for 8796612

• Fix typo: mask_compatability -> mask_compatibility

  Show description for 1257281
  bnmajor

  committed
  1257281

  Copy full SHA for 1257281

• Do not reset threshold data when toggling visibility

  Show description for a7973d3
  bnmajor

  committed
  a7973d3

  Copy full SHA for a7973d3

• Save masks by detector name under the "data" key

  Show description for ff03ccd
  bnmajor

  committed
  ff03ccd

  Copy full SHA for ff03ccd

Commits on Jan 16, 2024

• Move masks_changed signal to hide/show_all_masks functions

  Show description for 36c9da8
  bnmajor

  committed
  36c9da8

  Copy full SHA for 36c9da8

Commits on Jan 21, 2024

• Lazily compute masked arrays

  Show description for 8ec3332
  bnmajor

  committed
  8ec3332

  Copy full SHA for 8ec3332

Commits on Jan 22, 2024

• Set version as attribute instead of dataset

  Show description for 9fba4bf
  psavery

  committed
  9fba4bf

  Copy full SHA for 9fba4bf

• Only invalidate masks after setting data

  Show description for 16cb70c
  psavery

  committed
  16cb70c

  Copy full SHA for 16cb70c

• A few more fixes and minor refactoring...

  Show description for 9745a19
  psavery

  committed
  9745a19

  Copy full SHA for 9745a19