Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress mean of empty slice warnings in smooth_cal #960

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jsdillon
Copy link
Member

Nothing fancy here.

@jsdillon jsdillon requested a review from steven-murray July 16, 2024 23:58
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (75f0d94) to head (8e88bba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          31       31           
  Lines       10987    10989    +2     
=======================================
+ Hits        10681    10683    +2     
  Misses        306      306           
Flag Coverage Δ
unittests 97.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsdillon. Interestingly, I think these warnings randomly pop up because we're not always fixing the seed of the data-generation process. So we could get more in the future on other tests...

@steven-murray steven-murray merged commit 0e2852b into main Jul 17, 2024
8 of 9 checks passed
@jsdillon jsdillon deleted the sc-suppress-warnigns branch July 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants