Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff Rule A* (names shadowing builtins) #957

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Conversation

steven-murray
Copy link
Contributor

This should only be merged after #956

This adds rules that check for names shadowing python built-ins.

@steven-murray steven-murray requested a review from tyler-a-cox July 2, 2024 14:58
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (a0b3292) to head (0ed2783).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          31       31           
  Lines       10950    10950           
=======================================
  Hits        10652    10652           
  Misses        298      298           
Flag Coverage Δ
unittests 97.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tyler-a-cox tyler-a-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @steven-murray!

@tyler-a-cox tyler-a-cox merged commit 0188ab7 into main Jul 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants