Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove plan from report if comment is too long #35

Merged
merged 16 commits into from
May 21, 2024

Conversation

FurqanHabibi
Copy link
Contributor

@FurqanHabibi FurqanHabibi commented May 17, 2024

Tested.

Closes #17


BEGIN_COMMIT_OVERRIDE
feat: remove plan from report if comment is too long
END_COMMIT_OVERRIDE

@FurqanHabibi FurqanHabibi requested a review from hanscg May 17, 2024 06:29
@FurqanHabibi FurqanHabibi self-assigned this May 17, 2024
Copy link
Contributor

@hanscg hanscg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!
Do you think it's possible to remove the plan only from the PR comment but keep it in the workflow job summary?

The documentation says the limit for job summary is 1MB, which might be long enough for plans that are too long for the comments.
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#step-isolation-and-limits

@FurqanHabibi
Copy link
Contributor Author

@hanscg Kept the full report posted as job summary 🙏

@FurqanHabibi FurqanHabibi requested a review from hanscg May 17, 2024 08:38
Copy link
Contributor

@hanscg hanscg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the comment to say something like
"The plan is not output here because it's too long, check the workflow summary for full check result"

@FurqanHabibi
Copy link
Contributor Author

@hanscg Added the comment to check the workflow summary.

@FurqanHabibi FurqanHabibi requested a review from hanscg May 21, 2024 02:46
Copy link
Contributor

@hanscg hanscg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@FurqanHabibi FurqanHabibi merged commit 1b6d220 into main May 21, 2024
1 check passed
@FurqanHabibi FurqanHabibi deleted the fix-long-comment branch May 21, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check fails if comment is too long
2 participants