-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove plan from report if comment is too long #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Do you think it's possible to remove the plan only from the PR comment but keep it in the workflow job summary?
The documentation says the limit for job summary is 1MB, which might be long enough for plans that are too long for the comments.
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#step-isolation-and-limits
@hanscg Kept the full report posted as job summary 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the comment to say something like
"The plan is not output here because it's too long, check the workflow summary for full check result"
@hanscg Added the comment to check the workflow summary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Tested.
Closes #17
BEGIN_COMMIT_OVERRIDE
feat: remove plan from report if comment is too long
END_COMMIT_OVERRIDE