Skip to content

Commit

Permalink
cqfn#390 fix qulice reports
Browse files Browse the repository at this point in the history
  • Loading branch information
HDouss committed Feb 22, 2020
1 parent fe01130 commit da51e81
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/main/java/org/jpeek/Calculus.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
* @todo #390:30min We have a separate interface to calculate XML metrics.
* We should continue to the goal defined in #296 where we should have a java
* implementation to calculate metrics. The motivation is to be able to make
* calculations impossible or too difficult to implement in xsl.
* calculations impossible or too difficult to implement in xsl, like LCOM4.
*/
public interface Calculus {

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/jpeek/XslCalculus.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
* the xml containing the calculation.
* @since 0.1
*/
public class XslCalculus implements Calculus {
public final class XslCalculus implements Calculus {

@Override
public XML node(String metric, Map<String, Object> params, XML skeleton)
throws IOException {
public XML node(final String metric, final Map<String, Object> params,
final XML skeleton) throws IOException {
return new XSLDocument(
new TextOf(
new ResourceOf(
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/jpeek/XslReport.java
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ final class XslReport implements Report {
* @param name Name of metric
* @param args Params for XSL
* @param calc Calculus
* @checkstyle ParameterNumberCheck (5 lines)
*/
XslReport(final XML xml, final String name, final Map<String, Object> args,
final Calculus calc) {
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/org/jpeek/MetricsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
* @todo #323:30min This test is fully written against JUnit 4 API.
* Migrate this parametrized test to junit 5, so it won't import any classes from junit 4 anymore.
* @checkstyle JavadocTagsCheck (500 lines)
* @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
*
*/
@RunWith(Parameterized.class)
@SuppressWarnings({
Expand Down
1 change: 0 additions & 1 deletion src/test/java/org/jpeek/XslCalculusTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
* Test case for {@link XslCalculus}.
* @since 0.4
*/

public final class XslCalculusTest {

@Test
Expand Down

0 comments on commit da51e81

Please sign in to comment.