Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/user 카테고리 기능 추가 #96

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Feature/user 카테고리 기능 추가 #96

merged 5 commits into from
Jan 23, 2024

Conversation

EUNCHAEv1006
Copy link
Member

@EUNCHAEv1006 EUNCHAEv1006 commented Jan 23, 2024 •
edited
Loading

  • Setter 사용을 지양함
  • 카테고리 선택 기능 추가
  • 카카오로그인 헤더 수정

@EUNCHAEv1006 EUNCHAEv1006 added the enhancement New feature or request label Jan 23, 2024
@EUNCHAEv1006 EUNCHAEv1006 added this to the 유저 API 기능 구현 milestone Jan 23, 2024
@EUNCHAEv1006 EUNCHAEv1006 self-assigned this Jan 23, 2024
@EUNCHAEv1006 EUNCHAEv1006 linked an issue Jan 23, 2024 that may be closed by this pull request
[Feature] 카테고리 선택 - 취미 #95
Closed
wkdehdgk159
wkdehdgk159 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@wkdehdgk159 wkdehdgk159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프론트 API와 페이지가 하나 늘었군요.... 감사합니다!!!!!!!

src/main/java/com/HHive/hhive/domain/user/service/UserService.java Outdated

if (loginUser == null) {
throw new CustomException(ErrorCode.LOGIN_REQUIRED_EXCEPTION);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 유저가 null이 나오는 상황이 토큰이 없는 경우가 맞을까요?
맞다면 서비스 메소드 들어오기 전에 403이 뜰 것 같은데 다른 상황이 있으셨는지 궁금합니다!

kdy9960
kdy9960 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@kdy9960 kdy9960 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@EUNCHAEv1006 EUNCHAEv1006 merged commit 99d041f into dev Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy9960 kdy9960 kdy9960 approved these changes

@wkdehdgk159 wkdehdgk159 wkdehdgk159 approved these changes

Assignees

@EUNCHAEv1006 EUNCHAEv1006

Labels
enhancement New feature or request
Projects
None yet
Milestone
유저 API 기능 구현
Development

Successfully merging this pull request may close these issues.

[Feature] 카테고리 선택 - 취미
3 participants
@EUNCHAEv1006 @wkdehdgk159 @kdy9960