Feature/party 업데이트,조회 수정, 약속 시간 기능 추가 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkdehdgk159
approved these changes
Jan 18, 2024
EUNCHAEv1006
approved these changes
Jan 18, 2024
| Party party = partyRepository.findById(partyId).orElseThrow(PartyNotFoundException::new); | ||
| Party party = partyRepository.findById(partyId) | ||
| .filter(p -> !p.isDeleted()) // 삭제 되지 않은 파티만 필터링 | ||
| .orElseThrow(PartyNotFoundException::new); | ||
|
|
||
| List<MemberResponseDTO> members = partyUserRepository.findUsersByPartyId(partyId).stream() |
There was a problem hiding this comment.
getPartyDto메서드와 getUserPartyMap메서드에서 partyUserRepository.findUsersByPartyId를 MemberResponseDTO로 변환하는 로직이 중복되어 있는데, 이걸 메서드로 추출하지 않고 중복으로 사용한 이유가 있을까요?
| @@ -108,11 +130,19 @@ private Party getUserParty(Long partyId, User user) { | |||
| public void joinParty(Long partyId, User user) { | |||
| Party party = getUserParty(partyId, user); | |||
|
|
|||
| // 현재 날짜를 가져옵니다. | |||
| LocalDateTime now = LocalDateTime.now(); | |||
There was a problem hiding this comment.
다른 시간대를 다룰 경우를 대비해서 ZonedDateTime 사용은 어떠신가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.