Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 카카오 로그인 유저 이메일 수정 불가 + 테스트 코드 #113

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

EUNCHAEv1006
Copy link
Member

  • 카카오 로그인한 사용자가 이메일을 수정하려고 하면 KakaoUserEmailModificationException 예외가 발생합니다.

  • 테스트를 위해 setter를 사용했습니다.

  • build.gradle 수정
    //DB implementation 'com.h2database:h2' testImplementation 'com.h2database:h2' implementation 'com.mysql:mysql-connector-j'
  • 테스트를 실행할 때도 사용하기 위해서 수정하였습니다.

  • 주석 제거

@EUNCHAEv1006 EUNCHAEv1006 added the enhancement New feature or request label Jan 31, 2024
@EUNCHAEv1006 EUNCHAEv1006 added this to the 유저 API 기능 구현 milestone Jan 31, 2024
@EUNCHAEv1006 EUNCHAEv1006 self-assigned this Jan 31, 2024

import java.time.LocalDateTime;

@Entity
@Setter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세터를 쓴 이유를 잘 설명할 수 있어야할 것 같네요.
빌더로는 PK 세팅이 안되었나요? 이런 질문이 들어올 수 있을 것 같아요

Copy link
Collaborator

@mixedtape mixedtape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@EUNCHAEv1006 EUNCHAEv1006 merged commit ee9ab41 into dev Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] 유저 프로필 수정 [Feature] 소셜 로그인 기능 구현
3 participants