refactor : Hive 유저 탈퇴시 호스트 는 탈퇴불가 설정 예외처리 추가 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkdehdgk159
reviewed
Jan 31, 2024
| if (user.getId().equals(hive.getId())) { | ||
| throw new HostNotResignHiveException(); | ||
| } | ||
|
|
There was a problem hiding this comment.
엇 이러면 하이브 객체 아이디와 유저 객체 아이디를 비교하는 게 아닌가요?
There was a problem hiding this comment.
네 맞네요
이러면 아이디 순서대로 작성했던거랑 하이브 순서대로 만든거에대한 비교가 되버려서 잘못된거더군요
creatorId와 비교해서삭제가 안되겠끔 다시 수정했습니다.
wkdehdgk159
approved these changes
Jan 31, 2024
| if (user.getId().equals(hive.getId())) { | ||
| throw new HostNotResignHiveException(); | ||
| } | ||
|
|
EUNCHAEv1006
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.