Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: CommonResponse 형태 수정 및 validation 에러메시지 반환 #108

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Refactor: CommonResponse 형태 수정 및 validation 에러메시지 반환 #108

merged 2 commits into from
Jan 30, 2024

Conversation

wkdehdgk159
Copy link
Contributor

  1. CommonResponse에서 중복되던 상태코드를 빼주었습니다.(body에서 빼줌)
  2. 일부 틀린 상태코드를 수정하였습니다.(생성인데 200이라던지... 그리고 삭제같은 경우는 우리가 삭제 성공 메시지를 두기 때문에 204가 아닌 200으로 두었습니다.)
  3. jakarta.validation 에서 검증한 후 내뱉는 에러메시지를 @RestControllerAdvice를 이용하여 프론트에 반환하도록 수정하였습니다.

@wkdehdgk159 wkdehdgk159 self-assigned this Jan 29, 2024
kdy9960
kdy9960 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@kdy9960 kdy9960 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 내용 확인했습니다
고생하셨습니다

@wkdehdgk159 wkdehdgk159 merged commit 160b929 into dev Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy9960 kdy9960 kdy9960 approved these changes

@EUNCHAEv1006 EUNCHAEv1006 EUNCHAEv1006 approved these changes

Assignees

@wkdehdgk159 wkdehdgk159

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkdehdgk159 @EUNCHAEv1006 @kdy9960