Feature/hive 하이브 카테고리 별 조회기능 구현 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EUNCHAEv1006
approved these changes
Jan 24, 2024
| @@ -70,7 +72,18 @@ public ResponseEntity<CommonResponse> gethives() { | |||
| .body(new CommonResponse<>(200, "하이브들이 조회되었습니다.", responses)); | |||
| } | |||
|
|
|||
| @PatchMapping("{hive_id}") | |||
| @GetMapping("/search") | |||
| public ResponseEntity<CommonResponse> getHivesByCategory( | |||
There was a problem hiding this comment.
CommonResponse에 반환 타입을 넣어주는게 어떨까요?
예) CommonResponse<Void>
노션 - 코드 컨벤션에 나와있을거에요
| List<HiveResponseDTO> responses = hiveService.getHivesByCategory( | ||
| MajorCategory.findByStringName(majorCategory), SubCategory.findByStringName(subCategory)); | ||
| return ResponseEntity.ok() | ||
| .body(new CommonResponse<>(200, "하이브들이 조회되었습니다.", responses)); |
There was a problem hiding this comment.
200 대신 HttpStatus로 수정해주시면 더 좋을 듯 합니다
- 예시
return ResponseEntity.ok() .body(CommonResponse.of(HttpStatus.OK.value(), "카테고리 설정 성공", response));
| } | ||
|
|
||
|
|
||
| @DeleteMapping("{hive_id}") | ||
| public ResponseEntity<CommonResponse> deleteHive( |
There was a problem hiding this comment.
CommonResponse에 반환 타입을 넣어주는게 어떨까요?
예) CommonResponse<Void>
노션 - 코드 컨벤션에 나와있을거에요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.