Allow null to be passed as instance value #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-friedl
force-pushed
the
allowNullAsValue
branch
from
0e7f487 to
f80665e
Compare
|
When will this be merged in? We are having a bug in our production when setting the json field to This breaks |
|
We have verified that this patch fixes the cases when the input is Please apply this pull request, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to update a JsonField with a
nullvalue, even if allowNull is set to true.This PR allows
nullto be passed as a value for instances which may be wanted when updating certain records in the database.Also allowNull currently has no effect because the option is not passed to sequelize. This is fixed as well in this PR