Port Multiblocks to MUI2 #2672
Draft
Port Multiblocks to MUI2 #2672
+3,469
−1,266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
force-pushed
the
tc/mui2-multis
branch
3 times, most recently
from
55fefcd to
4dad110
Compare
ghzdude
force-pushed
the
tc/mui2-multis
branch
2 times, most recently
from
6b5159d to
87fdbca
Compare
4 tasks
ghzdude
force-pushed
the
tc/mui2-multis
branch
from
a82d411 to
22536c3
Compare
port MultiblockDisplayText to mui2
almost everything mui2 related is moved into MultiblockUIFactory fix issues with cyclebutton widget textures fix syncing (at least for EBF) probably other things i don't feel like writing about
fix distinct bus button more work on MultiblockUIFactory bars work again
add ByteSyncValue implement blinking logos
add dynamic keys add helper methods
use list instead of consumer move margin to power button instead of flex
add note for dynamic texture
add multiblock name make steam output dynamic
truncate PSS stored/capacity show full amount in hoverable tooltip
only add muffler and maint line they're enabled
ghzdude
force-pushed
the
tc/mui2-multis
branch
from
2b804a0 to
0dfce00
Compare
Prevent the mode button from being pressed while active. Revert flex button texture split.
…kingUnit, MetaTileEntityElectricBlastFurnace, MetaTileEntityLargeBoiler, MetaTileEntityLargeCombustionEngine, MetaTileEntityLargeTurbine, MetaTileEntityMultiSmelter, MetaTileEntityProcessingArray, MetaTileEntityPyrolyseOven, MetaTileEntityResearchStation, and RecipeMapMultiblockController.
)deprecate methods and schedule removal remove SECTION add notes
… use KeyUtil.number for the other two lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ports every multiblock with a UI to use MUI2.
Implementation Details
MultiMapMultiblockControllerwill need to be updated (GCYM) or overrideusesMui2()to return false.KeyUtilsto replaceTextComponantUtilcreateUIFactory()to create needed sync values and return a configuredMultiblockUIFactorycreateUIFactory()is called duringwriteInitialSyncData()andreceiveInitialSyncData()so that values can be synced correctly before the ui is openedCurrently ported multis are:
Outcome
multiblock uis are fancier