Improve naming 4 - WalkTo, turn, hits and misc

[GregHib]

Closes #580

• Fix teleport/stairs/ladder delays
• Simplify NPC and Player setup and visuals
• Move remainder visual functions
• Move Entity.size into Character
• Fix door entry

[github-actions]

Qodana Community for JVM

2 new problems were found

Inspection name	Severity	Problems
Unused import directive	🔶 Warning	2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

Attention: Patch coverage is 45.40230% with 95 lines in your changes missing coverage. Please review.

Project coverage is 34.91%. Comparing base (08b0acf) to head (d3f874a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../gregs/voidps/engine/entity/character/Character.kt	20.00%	41 Missing and 3 partials ⚠️
.../gregs/voidps/engine/suspend/SuspendableContext.kt	0.00%	11 Missing ⚠️
...regs/voidps/world/interact/entity/obj/door/Door.kt	61.53%	3 Missing and 2 partials ⚠️
...ld/gregs/voidps/engine/entity/character/Visuals.kt	0.00%	3 Missing ⚠️
...activity/skill/agility/course/WildernessCourse.kts	78.57%	3 Missing ⚠️
...voidps/world/command/debug/NPCUpdatingCommands.kts	0.00%	3 Missing ⚠️
...ld/gregs/voidps/engine/entity/character/npc/NPC.kt	75.00%	1 Missing and 1 partial ⚠️
...gregs/voidps/world/command/debug/DebugCommands.kts	0.00%	2 Missing ⚠️
...dps/world/command/debug/PlayerUpdatingCommands.kts	0.00%	2 Missing ⚠️
.../map/tree_gnome_stronghold/TreeGnomeStronghold.kts	0.00%	2 Missing ⚠️
... and 14 more

Additional details and impacted files

Files with missing lines	Coverage Δ
...ps/engine/client/instruction/handle/WalkHandler.kt	0.00% <ø> (ø)
...s/voidps/engine/client/update/npc/NPCUpdateTask.kt	68.51% <100.00%> (ø)
...n/world/gregs/voidps/engine/data/AccountManager.kt	72.83% <100.00%> (-0.34%)	⬇️
.../kotlin/world/gregs/voidps/engine/entity/Entity.kt	0.00% <ø> (ø)
.../gregs/voidps/engine/entity/character/mode/Face.kt	0.00% <ø> (ø)
...regs/voidps/engine/entity/character/mode/Follow.kt	0.00% <ø> (ø)
...egs/voidps/engine/entity/character/mode/Retreat.kt	0.00% <ø> (ø)
...ine/entity/character/mode/combat/CombatMovement.kt	0.00% <ø> (ø)
.../engine/entity/character/mode/interact/Interact.kt	60.22% <ø> (ø)
...idps/engine/entity/character/mode/move/Movement.kt	65.11% <ø> (ø)
... and 70 more

... and 3 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #599      +/-   ##
============================================
+ Coverage     34.86%   34.91%   +0.04%     
- Complexity     4884     4885       +1     
============================================
  Files          1339     1338       -1     
  Lines         47123    47101      -22     
  Branches       9512     9500      -12     
============================================
+ Hits          16430    16445      +15     
+ Misses        27306    27276      -30     
+ Partials       3387     3380       -7     

Components	Coverage Δ
Content	28.62% <64.86%> (+0.02%)	⬆️
Engine	43.49% <29.88%> (+0.15%)	⬆️
Network	71.92% <38.46%> (+0.07%)	⬆️