Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add barbarian agility courses and barcrawl miniquest #575

Merged
merged 13 commits into from
Jan 5, 2025
Merged

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jan 5, 2025

  • Add barbarian basic course
  • Add barbarian advanced course
  • Add Alfred Grimhand's barcrawl mini-quest
  • Add all bartenders
  • Add tree gnome stronghold door and stairs
  • Add vial smashing
  • Add shared agility stage and course variables
  • Add differing scroll interfaces
  • Add buy single item helper function

Copy link

github-actions bot commented Jan 5, 2025

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 49.89858% with 494 lines in your changes missing coverage. Please review.

Project coverage is 34.56%. Comparing base (5e78b50) to head (c0e7b2a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../voidps/world/map/falador/BarmaidsRisingSunInn.kts 35.71% 60 Missing and 3 partials ⚠️
...dps/world/map/barbarian_outpost/BarbarianGuard.kts 26.50% 55 Missing and 6 partials ⚠️
...s/world/activity/skill/agility/course/Gunnjorn.kts 2.56% 38 Missing ⚠️
...world/map/seers_village/BartenderForestersArms.kts 36.00% 30 Missing and 2 partials ⚠️
.../voidps/world/map/varrock/BartenderBlueMoonInn.kts 45.28% 27 Missing and 2 partials ⚠️
...activity/skill/agility/course/BarbarianOutpost.kts 84.00% 6 Missing and 18 partials ⚠️
...gs/voidps/world/map/yanille/BartenderDragonInn.kts 42.85% 22 Missing and 2 partials ⚠️
...ld/activity/quest/mini/AlfredGrimhandsBarCrawl.kts 0.00% 22 Missing ⚠️
...voidps/world/map/varrock/BartenderJollyBoarInn.kts 48.78% 20 Missing and 1 partial ⚠️
...rld/activity/skill/agility/course/GnomeTrainer.kts 0.00% 20 Missing ⚠️
... and 20 more
Additional details and impacted files
Files with missing lines Coverage Δ
...dps/world/activity/skill/agility/course/Agility.kt 100.00% <100.00%> (ø)
...orld/activity/skill/agility/course/GnomeAgility.kt 62.50% <ø> (-16.08%) ⬇️
...idps/world/map/tree_gnome_stronghold/Brimstail.kts 9.09% <ø> (ø)
.../instruction/handle/InterfaceOnNPCOptionHandler.kt 0.00% <0.00%> (ø)
...regs/voidps/world/activity/quest/GunnarsGround.kts 4.10% <0.00%> (ø)
...gregs/voidps/world/command/admin/AdminCommands.kts 3.14% <0.00%> (-0.01%) ⬇️
...ntity/character/mode/move/target/TargetStrategy.kt 53.57% <0.00%> (-4.13%) ⬇️
...ld/activity/skill/agility/course/GnomeAdvanced.kts 86.20% <84.61%> (+15.75%) ⬆️
...d/interact/entity/player/combat/consume/Eating.kts 61.90% <33.33%> (-7.33%) ⬇️
.../activity/skill/agility/course/GnomeStronghold.kts 76.99% <73.68%> (+0.84%) ⬆️
... and 23 more

... and 10 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #575      +/-   ##
============================================
+ Coverage     34.13%   34.56%   +0.43%     
- Complexity     4807     4847      +40     
============================================
  Files          1323     1342      +19     
  Lines         46129    47044     +915     
  Branches       9376     9509     +133     
============================================
+ Hits          15744    16263     +519     
- Misses        27055    27388     +333     
- Partials       3330     3393      +63     
Components Coverage Δ
Content 28.35% <50.35%> (+1.02%) ⬆️
Engine 43.16% <0.00%> (-0.04%) ⬇️
Network 70.69% <ø> (ø)

@GregHib GregHib merged commit c4c2bb6 into main Jan 5, 2025
5 checks passed
@GregHib GregHib deleted the barbarian-agility branch January 5, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant