Add npc pick-pocketing for thieving skill

[GregHib]

#485

• Added stun mechanic
• Added npc pick-pocketing
• Add pickpocket loot to drops.yaml
• Add man/woman/human pick-pocketing

Doesn't include success boosts like gloves of silence or ardy diary

Making an npc pick-pocket-able by adding data in npcs.yaml

pickpocket:
    stun_hit: 10
    stun_ticks: 8
    xp: 14.5
    chance: 150-240
    caught: "Cor blimey mate, what are ye doing in me pockets?"

Add drops by specifying a drop table with the npc id or race followed by _pickpocket. e.g. woman_4_pickpocket, farmer_pickpocket

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

Attention: Patch coverage is 64.39394% with 47 lines in your changes missing coverage. Please review.

Project coverage is 33.96%. Comparing base (c25482d) to head (26edf36).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ps/world/activity/skill/thieving/Pickpocketing.kts	72.00%	4 Missing and 10 partials ⚠️
.../gregs/voidps/engine/data/yaml/DefinitionConfig.kt	57.89%	3 Missing and 5 partials ⚠️
.../gregs/voidps/world/interact/entity/effect/Stun.kt	52.94%	5 Missing and 3 partials ⚠️
...idps/world/interact/entity/npc/combat/NPCAttack.kt	41.66%	4 Missing and 3 partials ⚠️
...gregs/voidps/engine/data/definition/data/Pocket.kt	64.70%	0 Missing and 6 partials ⚠️
...gine/client/instruction/handle/NPCOptionHandler.kt	0.00%	3 Missing ⚠️
...voidps/world/interact/entity/npc/combat/Attack.kts	50.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
...s/voidps/engine/data/definition/ItemDefinitions.kt	75.94% <ø> (+3.50%)	⬆️
...gs/voidps/engine/data/definition/NPCDefinitions.kt	92.85% <100.00%> (+2.38%)	⬆️
.../gregs/voidps/engine/entity/item/drop/DropTable.kt	75.34% <ø> (ø)
...voidps/world/interact/entity/npc/combat/Attack.kts	38.88% <50.00%> (-0.70%)	⬇️
...gine/client/instruction/handle/NPCOptionHandler.kt	0.00% <0.00%> (ø)
...gregs/voidps/engine/data/definition/data/Pocket.kt	64.70% <64.70%> (ø)
...idps/world/interact/entity/npc/combat/NPCAttack.kt	41.66% <41.66%> (ø)
.../gregs/voidps/engine/data/yaml/DefinitionConfig.kt	77.14% <57.89%> (-22.86%)	⬇️
.../gregs/voidps/world/interact/entity/effect/Stun.kt	52.94% <52.94%> (ø)
...ps/world/activity/skill/thieving/Pickpocketing.kts	72.00% <72.00%> (ø)

... and 6 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #567      +/-   ##
============================================
+ Coverage     33.90%   33.96%   +0.06%     
- Complexity     4787     4806      +19     
============================================
  Files          1315     1319       +4     
  Lines         45779    45873      +94     
  Branches       9311     9337      +26     
============================================
+ Hits          15522    15582      +60     
- Misses        26972    26989      +17     
- Partials       3285     3302      +17     

Components	Coverage Δ
Content	26.95% <62.96%> (+0.09%)	⬆️
Engine	43.21% <66.66%> (+0.06%)	⬆️
Network	70.69% <ø> (ø)