Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom parameters more intuitive, few fixes #141

Merged
merged 9 commits into from
Dec 29, 2024

Conversation

Fort-TM
Copy link
Contributor

@Fort-TM Fort-TM commented Dec 22, 2024

This PR tries to partially address #102, since I also got confused about them before. The changes are mostly visual and don't affect functionality

  • Make custom rules checkbox text generic, since they affect all game modes as far as I know.
  • Disable all custom parameters if the custom rules checkbox isn't enabled. This should make it clear that you need to enable this setting to use them.
  • Include tag count when there's any tag selected and sort them alphabetically
    image
  • Add tooltips for the tag inclusive and skip seen maps checkboxes

This PR also fixes the following issues:

  • Minimum value for the year slider was 2020 for MP4 too
  • Date interval table used the same name as the tags table. This would shrink the tags table when the date interval one was rendered
  • Date intervals values weren't being reset when resetting parameters to default

This was included in a single PR because the changes are small and related to the custom parameters tab

@GreepTheSheep GreepTheSheep merged commit edbfb41 into GreepTheSheep:main Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants