Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): implement settings page component with links #322

Merged

Conversation

kshitij79
Copy link
Contributor

@kshitij79 kshitij79 commented Jan 1, 2025

Description

Implemented the settings page component, which displays a list of navigation links for various settings sections such as Account, Notifications, Privacy, etc. Each item leads to a different page to manage respective settings, providing a structured and user-friendly layout.

Fixes: #304
or
Resolves: # (issue number)


Changes Made

  • Changes in apps folder (specify the app and briefly describe the changes):

    • Web: Added a settings page component with navigation links for different settings sections like Account, Notifications, and others.
    • Native
  • Changes in packages folder (specify the package and briefly describe the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Before After
Screenshot 2025-01-01 at 1 51 25 PM Screenshot 2025-01-01 at 1 50 53 PM

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

(Optional) Add any additional comments or notes for reviewers here.

@kshitij79 kshitij79 requested a review from a team as a code owner January 1, 2025 18:52
@pierrelstan pierrelstan self-requested a review January 9, 2025 15:30
@pierrelstan pierrelstan merged commit 8c1333a into Greenstand:main Jan 9, 2025
2 checks passed
@pierrelstan
Copy link
Collaborator

@kshitij79 Thank you for your work !

Copy link

@catdon5 catdon5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants