Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goliath: Various Updates #210

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

HellDragon-HK
Copy link
Contributor

No description provided.

@GreatEmerald
Copy link
Owner

You have broken the Goliath file by overwriting it (see https://travis-ci.org/GreatEmerald/UT3Vehicles). You need to re-overwrite it with the old file now so that the build succeeds, then upload your new file with a new name, and update Binaries.csv in this pull request.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

Ver 1 is still there, uploaded Dec 19 2017 10:13 PM, is that not the right one?

@GreatEmerald
Copy link
Owner

The file https://drive.google.com/uc?export=download&id=1uFWoDVvJpaGgDzxAYA8KkGT6Ija4CRKI must match the checksum f2c9cafc34d60ec4321d1402cee7e8345a31265f86a3e85667e6e31d77bd8ed0. It is currently 7282b51bc6b321c39ee88b8ad8082d9313e8d5c2205498e7393c5058401c3a26. Recheck your versions to see which one corresponds to which.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

Ver 1 is f2c9cafc34d60ec4321d1402cee7e8345a31265f86a3e85667e6e31d77bd8ed0, I get a green check and I just downloaded it from G-Drive so it is the right one

@GreatEmerald
Copy link
Owner

Then why is the URL pointing to some other (version of the) file?

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

The versions stack with the new one having the same url & name while the old one is still there in manage versions but I can't do much with it other than download and delete

It might be possible to use a new folder to manage this issue unless it can only have 1 of the same name anywhere

@GreatEmerald
Copy link
Owner

Yea, so that's the problem. You need to make sure the names are all unique, so that Google assigns new URLs to them. You can fix this by re-uploading Ver 1 with the same name as you used originally, which should make the URL point back to Ver 1. Then for Ver 2 upload it with a different name or in a different folder.

@HellDragon-HK
Copy link
Contributor Author

Which would be more preferable as a different name will also cause build issues won't it?

@GreatEmerald
Copy link
Owner

No, names on your Google Drive don't matter at all. The FetchBinaries.sh script renames all files to the names in Binaries.csv, so that they are always correct.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

Ok didn't know that, so I'll mark them with Ver# then from now on
Goliath should be fixed now btw

@GreatEmerald
Copy link
Owner

Yeap, that will work. Just make sure to fix the one without a version so it's Ver 1.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

Rename doesn't break file paths so shouldn't be an issue.....unless it breaks the checksum...does it?

@GreatEmerald
Copy link
Owner

I guess? Let me know when that URL points back to Ver 1 so I can retrigger the Binaries.csv consistency check.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

I think it does now

So technically I didn't actually break rule # 1 right?

@GreatEmerald
Copy link
Owner

Yeap, it works now! Now the Hellbender sound file is mismatched. Let me know when you fix all the files.

Well, you did from the URL perspective, but not from the file perspective. Which makes it all good as long as you can fix the URLs again.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

I think I can, just point them out as they come I guess, btw welcome back.
Try something different this time, delete the newer version and leave only the old.

@HellDragon-HK
Copy link
Contributor Author

Hellbender should be fixed

@GreatEmerald
Copy link
Owner

And there you go, Travis has picked up this Pull Request and is telling you that Binaries.csv is still inconsistent. If you press on Details and scroll to the very end, you can see which file failed.

I'll also set up a cache so that it doesn't redownload all files every time it tries to check it.

@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Feb 5, 2018

I really don't know how to read that mess GE, I can't see what it's complaining about.

EDIT - Nvm I see it now and I already fixed it before you commented actually

@GreatEmerald
Copy link
Owner

Yeap, the check passes now! All files are fixed, thanks.

@HellDragon-HK HellDragon-HK changed the title Goliath: Multi Sound Update Goliath: Sound Updates Feb 5, 2018
@HellDragon-HK HellDragon-HK changed the title Goliath: Sound Updates Goliath: Sound Updates WIP Mar 2, 2018
@HellDragon-HK HellDragon-HK changed the title Goliath: Sound Updates WIP Goliath: Sound Updates Mar 16, 2018
@HellDragon-HK HellDragon-HK changed the title Goliath: Sound Updates Goliath: Various Updates Mar 16, 2018
@HellDragon-HK
Copy link
Contributor Author

HellDragon-HK commented Mar 16, 2018

I really really hate this Travis CI thing GE, everything I do it complains about which usually results in having to re-upload a file to get a new link and hope it passes, this time I can't even tell what it's complaining about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants