-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Examples #36
Draft
jakejackson1
wants to merge
14
commits into
main
Choose a base branch
from
refactor-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bb11c4
to
5fa665f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=========================================
Coverage 88.41% 88.41%
Complexity 1349 1349
=========================================
Files 26 26
Lines 3124 3124
=========================================
Hits 2762 2762
Misses 362 362 ☔ View full report in Codecov by Sentry. |
8cf04b0
to
ee2e99f
Compare
c1dcfa7
to
4c0100b
Compare
4c0100b
to
d9e304d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize and Refactor the examples included in the /examples/ directory.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Many of the examples are outdated and/or broken.
What is the new behavior?
Organize each example into a subdirectory for easier browsing, refactor the code, fix up any broken code, make it easier to understand, and rename.
Does this introduce a breaking change?
Other information
This is a WIP. Once done, I'm considering migrating the examples into their own repo, so people can clone the repo, composer install, and then directly access each example to see what it does.