Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nix build issues on aarch64-darwin #482

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix nix build issues on aarch64-darwin #482

merged 2 commits into from
Feb 20, 2024

Conversation

trevorbernard
Copy link
Contributor

@trevorbernard trevorbernard marked this pull request as draft February 18, 2024 18:23
@trevorbernard trevorbernard self-assigned this Feb 18, 2024
@trevorbernard trevorbernard marked this pull request as ready for review February 18, 2024 18:56
@trevorbernard trevorbernard changed the title Fix nix build issues on darwin Fix nix build issues on aarch64-darwin Feb 18, 2024
@trevorbernard
Copy link
Contributor Author

@robinbb can you see if this fix also fixes your x86_64-darwin woes as well?

@jhult
Copy link
Member

jhult commented Feb 18, 2024

This appears to fix it for me on an Apple M1.

@trevorbernard trevorbernard force-pushed the fix-nix-flakes-on-darwin branch from c79a842 to 7434a8c Compare February 20, 2024 00:10
@trevorbernard trevorbernard mentioned this pull request Feb 20, 2024
Merged
@robinbb robinbb assigned robinbb and unassigned Isaac-DeFrain Feb 20, 2024
robinbb
robinbb approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@robinbb robinbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes nothing for me on MacOS/Intel, but it's obviously still net positive.

@robinbb robinbb merged commit 81dcbe8 into Granola-Team:main Feb 20, 2024
3 checks passed
@trevorbernard trevorbernard deleted the fix-nix-flakes-on-darwin branch February 20, 2024 02:09
@trevorbernard
Copy link
Contributor Author

This changes nothing for me on MacOS/Intel, but it's obviously still net positive.

My workflow depends on the nix working. It was slowing me down

@robinbb
Copy link
Member

robinbb commented Feb 20, 2024 •
edited
Loading

Well worth doing this fix, @trevorbernard !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinbb robinbb robinbb approved these changes

@Isaac-DeFrain Isaac-DeFrain Awaiting requested review from Isaac-DeFrain

Assignees

@robinbb robinbb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: nix builds are broken on aarch64-darwin
4 participants
@trevorbernard @jhult @robinbb @Isaac-DeFrain