-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add universal2 arch for macos builds #281
feat: add universal2 arch for macos builds #281
Conversation
b1d94cd
to
5708baf
Compare
This is what GitHub actions produces now when do a test run. Is this what you expect? What are the benefits/requirement for having a universal wheel for macOS? I wasn't aware such a thing existed before you pointed it out.
|
@GrahamDumpleton the benefit is that the wheel runs on both architecture types for macos so there's no need to have individual The importance here is that this package |
Try |
@GrahamDumpleton this is great thank you! |
@GrahamDumpleton I realized that what I needed was a
universal2
binary forwrapt
on macos. I made a PR on my fork here which should have what you need to approve, but let me know if this works for you