Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add universal2 arch for macos builds #281

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Jan 13, 2025

@GrahamDumpleton I realized that what I needed was a universal2 binary for wrapt on macos. I made a PR on my fork here which should have what you need to approve, but let me know if this works for you

@GrahamDumpleton
Copy link
Owner

This is what GitHub actions produces now when do a test run. Is this what you expect? What are the benefits/requirement for having a universal wheel for macOS? I wasn't aware such a thing existed before you pointed it out.

wrapt-1.17.1-cp310-cp310-macosx_10_9_universal2.whl
wrapt-1.17.1-cp310-cp310-macosx_10_9_x86_64.whl
wrapt-1.17.1-cp310-cp310-macosx_11_0_arm64.whl
wrapt-1.17.1-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp310-cp310-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp310-cp310-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp310-cp310-musllinux_1_2_i686.whl
wrapt-1.17.1-cp310-cp310-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp310-cp310-win32.whl
wrapt-1.17.1-cp310-cp310-win_amd64.whl
wrapt-1.17.1-cp311-cp311-macosx_10_9_universal2.whl
wrapt-1.17.1-cp311-cp311-macosx_10_9_x86_64.whl
wrapt-1.17.1-cp311-cp311-macosx_11_0_arm64.whl
wrapt-1.17.1-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp311-cp311-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp311-cp311-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp311-cp311-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp311-cp311-musllinux_1_2_i686.whl
wrapt-1.17.1-cp311-cp311-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp311-cp311-win32.whl
wrapt-1.17.1-cp311-cp311-win_amd64.whl
wrapt-1.17.1-cp312-cp312-macosx_10_13_universal2.whl
wrapt-1.17.1-cp312-cp312-macosx_10_13_x86_64.whl
wrapt-1.17.1-cp312-cp312-macosx_11_0_arm64.whl
wrapt-1.17.1-cp312-cp312-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp312-cp312-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp312-cp312-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp312-cp312-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp312-cp312-musllinux_1_2_i686.whl
wrapt-1.17.1-cp312-cp312-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp312-cp312-win32.whl
wrapt-1.17.1-cp312-cp312-win_amd64.whl
wrapt-1.17.1-cp313-cp313-macosx_10_13_universal2.whl
wrapt-1.17.1-cp313-cp313-macosx_10_13_x86_64.whl
wrapt-1.17.1-cp313-cp313-macosx_11_0_arm64.whl
wrapt-1.17.1-cp313-cp313-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp313-cp313-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp313-cp313-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp313-cp313-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp313-cp313-musllinux_1_2_i686.whl
wrapt-1.17.1-cp313-cp313-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp313-cp313-win32.whl
wrapt-1.17.1-cp313-cp313-win_amd64.whl
wrapt-1.17.1-cp313-cp313t-macosx_10_13_universal2.whl
wrapt-1.17.1-cp313-cp313t-macosx_10_13_x86_64.whl
wrapt-1.17.1-cp313-cp313t-macosx_11_0_arm64.whl
wrapt-1.17.1-cp313-cp313t-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp313-cp313t-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp313-cp313t-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp313-cp313t-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp313-cp313t-musllinux_1_2_i686.whl
wrapt-1.17.1-cp313-cp313t-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp313-cp313t-win32.whl
wrapt-1.17.1-cp313-cp313t-win_amd64.whl
wrapt-1.17.1-cp38-cp38-macosx_10_9_universal2.whl
wrapt-1.17.1-cp38-cp38-macosx_10_9_x86_64.whl
wrapt-1.17.1-cp38-cp38-macosx_11_0_arm64.whl
wrapt-1.17.1-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp38-cp38-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp38-cp38-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp38-cp38-musllinux_1_2_i686.whl
wrapt-1.17.1-cp38-cp38-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp38-cp38-win32.whl
wrapt-1.17.1-cp38-cp38-win_amd64.whl
wrapt-1.17.1-cp39-cp39-macosx_10_9_universal2.whl
wrapt-1.17.1-cp39-cp39-macosx_10_9_x86_64.whl
wrapt-1.17.1-cp39-cp39-macosx_11_0_arm64.whl
wrapt-1.17.1-cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
wrapt-1.17.1-cp39-cp39-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
wrapt-1.17.1-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
wrapt-1.17.1-cp39-cp39-musllinux_1_2_aarch64.whl
wrapt-1.17.1-cp39-cp39-musllinux_1_2_i686.whl
wrapt-1.17.1-cp39-cp39-musllinux_1_2_x86_64.whl
wrapt-1.17.1-cp39-cp39-win32.whl
wrapt-1.17.1-cp39-cp39-win_amd64.whl
wrapt-1.17.1-py3-none-any.whl
wrapt-1.17.1.tar.gz

@thomasrockhu-codecov
Copy link
Contributor Author

@GrahamDumpleton the benefit is that the wheel runs on both architecture types for macos so there's no need to have individual arm64 and x86_64 wheels (unless of course there is a use case for it).

The importance here is that this package wrapt is used downstream by opentelemetry and my current system needs a fat binary (universal2) in order to properly build.

@GrahamDumpleton GrahamDumpleton merged commit a43042f into GrahamDumpleton:develop Jan 14, 2025
36 checks passed
@GrahamDumpleton
Copy link
Owner

Try wrapt==1.17.2 and see if it satisfies your requirements.

@thomasrockhu-codecov
Copy link
Contributor Author

@GrahamDumpleton this is great thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants