Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wagmi 2.2 #8

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Upgrade wagmi 2.2 #8

merged 3 commits into from
Jan 19, 2024

Conversation

alexandrugu
Copy link
Contributor

No description provided.

@alexandrugu alexandrugu requested review from callmephilip and stas and removed request for callmephilip and stas January 17, 2024 16:18
@alexandrugu
Copy link
Contributor Author

@stas, @callmephilip i've updated govNFT to the latest wagmi. Please have a look and let me know what you think.

There's a change on the way they manage connectors, and this will load more injected wallets into the connect screen. I think the design / workflow can be improved a bit more there, but I suggest we do a separate PR for that.

@callmephilip
Copy link

lol. i've just started migrating to new Wagmi in velodrome. i'll take a look once i am done on my side here

Copy link
Contributor

@stas stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, left a suggestion related to where we leave the config, otherwise it looks good.

Btw, related to the injected connectors, please review this option, it might be the reason why more connectors show up:
https://wagmi.sh/core/api/createConfig#multiinjectedproviderdiscovery

@alexandrugu
Copy link
Contributor Author

@stas / @callmephilip multiInjectedProviderDiscovery: false, worked! Thank you!

@alexandrugu
Copy link
Contributor Author

@stas i've updated the custom RPC. Can you please have another look here, see if you notice anything else? 🙏 TY!

Copy link
Contributor

@stas stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small suggestions.

@alexandrugu alexandrugu merged commit 8992201 into main Jan 19, 2024
3 checks passed
@alexandrugu alexandrugu deleted the upgrade-wagmi branch January 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants