-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wagmi 2.2 #8
Conversation
@stas, @callmephilip i've updated govNFT to the latest wagmi. Please have a look and let me know what you think. There's a change on the way they manage connectors, and this will load more injected wallets into the connect screen. I think the design / workflow can be improved a bit more there, but I suggest we do a separate PR for that. |
lol. i've just started migrating to new Wagmi in velodrome. i'll take a look once i am done on my side here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, left a suggestion related to where we leave the config, otherwise it looks good.
Btw, related to the injected connectors, please review this option, it might be the reason why more connectors show up:
https://wagmi.sh/core/api/createConfig#multiinjectedproviderdiscovery
@stas / @callmephilip multiInjectedProviderDiscovery: false, worked! Thank you! |
@stas i've updated the custom RPC. Can you please have another look here, see if you notice anything else? 🙏 TY! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small suggestions.
No description provided.