Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TaskChampion-2.0.2 #38

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

djmitche
Copy link
Collaborator

@djmitche djmitche commented Jan 6, 2025

This includes a fix for GothenburgBitFactory/taskchampion#527. For taskchampion-py it's a simple version bump.

@djmitche djmitche enabled auto-merge (squash) January 6, 2025 18:10
@djmitche djmitche requested a review from illya-laifu January 6, 2025 18:10
@illya-laifu
Copy link
Collaborator

Seems like the clippy report step cannot be completed on the forked repos.

https://github.com/actions-rs/clippy-check/blob/b5b5f21f4797c02da247df37026fcd0a5024aa4d/README.md?plain=1#L70

Limitations
Due to token permissions, this Action WILL NOT be able to post clippy annotations for Pull Requests from the forked repositories.

@djmitche
Copy link
Collaborator Author

djmitche commented Jan 7, 2025

I think that's because the PR is from another repository (my fork).

@djmitche djmitche disabled auto-merge January 7, 2025 15:16
@djmitche djmitche merged commit 52fae0b into GothenburgBitFactory:master Jan 7, 2025
21 checks passed
@djmitche
Copy link
Collaborator Author

djmitche commented Jan 7, 2025

Sorry, I didn't read the whole comment before replying from my phone this morning.

I think this is OK -- the check will still fail if any denied lints are detected, but it won't put comments in the PR diff. If that happens it's straightforward to run cargo clippy (or even cargo clippy --fix) locally to see the same output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants