Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example with Cloud Run function that monitors events. #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arthurlapertosa
Copy link

No description provided.

@arthurlapertosa arthurlapertosa marked this pull request as ready for review December 11, 2024 19:52
@arthurlapertosa arthurlapertosa requested review from q2w and a team as code owners December 11, 2024 19:52
@arthurlapertosa
Copy link
Author

@apeabody could you please run the build o this PR?

@arthurlapertosa
Copy link
Author

Hi @erlanderlo!

During our internal review, we discussed renaming this example examples/cloud-run to examples/monitoring_secrets_using_cloud_run to provide more clarity. Currently, the examples in this repository use simpler names like pub-sub and monitoring-alert.
While descriptive names might offer better clarity, shorter names enhance readability and avoid issues with long names being cropped by some OS interfaces. For an instance, we could keep cloud-run and provide detailed explanations in the README.md.
Could you please share your thoughts on whether we should adopt more descriptive names or stick with the simpler naming convention followed by this repository?

@apeabody
Copy link
Contributor

/gcbrun

@arthurlapertosa
Copy link
Author

Hi, @gptSanyam! Elo told me to add you as reviewer in this PR as well! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants