-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(securitycenter): Add Resource SCC Management API Org SHA Custom … #3952
base: main
Are you sure you want to change the base?
Changes from 2 commits
2c7724b
8e59941
56f7fdf
ca57588
88fb3e8
3dba0a5
5168568
d25ad5b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,99 @@ | ||||||||||
// Copyright 2025 Google LLC | ||||||||||
// | ||||||||||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||
// you may not use this file except in compliance with the License. | ||||||||||
// You may obtain a copy of the License at | ||||||||||
// | ||||||||||
// http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||
// | ||||||||||
// Unless required by applicable law or agreed to in writing, software | ||||||||||
// distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||
// See the License for the specific language governing permissions and | ||||||||||
// limitations under the License. | ||||||||||
'use strict'; | ||||||||||
|
||||||||||
/** | ||||||||||
* Create security health analytics custom module | ||||||||||
*/ | ||||||||||
function main(organizationId, customModuleDisplayName, locationId = 'global') { | ||||||||||
// [START securitycenter_create_security_health_analytics_custom_module] | ||||||||||
// npm install '@google-cloud/securitycentermanagement' | ||||||||||
const { | ||||||||||
SecurityCenterManagementClient, | ||||||||||
protos, | ||||||||||
} = require('@google-cloud/securitycentermanagement'); | ||||||||||
|
||||||||||
const client = new SecurityCenterManagementClient(); | ||||||||||
|
||||||||||
const EnablementState = | ||||||||||
protos.google.cloud.securitycentermanagement.v1 | ||||||||||
.SecurityHealthAnalyticsCustomModule.EnablementState; | ||||||||||
|
||||||||||
const Severity = | ||||||||||
protos.google.cloud.securitycentermanagement.v1.CustomConfig.Severity; | ||||||||||
|
||||||||||
/* | ||||||||||
* Required. The name of the parent resource of security health analytics module | ||||||||||
* Its format is | ||||||||||
* `organizations/[organization_id]/locations/[location_id]` | ||||||||||
* `folders/[folder_id]/locations/[location_id]` | ||||||||||
* `projects/[project_id]/locations/[location_id]` | ||||||||||
*/ | ||||||||||
const parent = `organizations/${organizationId}/locations/${locationId}`; | ||||||||||
|
||||||||||
/* | ||||||||||
* Required. Resource name of security health analytics module. | ||||||||||
* Its format is | ||||||||||
* `organizations/[organization_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||||||||||
* `folders/[folder_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||||||||||
* `projects/[project_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||||||||||
*/ | ||||||||||
const name = `organizations/${organizationId}/locations/${locationId}/securityHealthAnalyticsCustomModules/custom_module`; | ||||||||||
|
||||||||||
// define the CEL expression here and this will scans for keys that have not been rotated in | ||||||||||
// the last 30 days, change it according to your requirements | ||||||||||
const expr = { | ||||||||||
expression: `has(resource.rotationPeriod) && (resource.rotationPeriod > duration('2592000s'))`, | ||||||||||
}; | ||||||||||
|
||||||||||
// define the resource selector | ||||||||||
const resourceSelector = { | ||||||||||
resourceTypes: ['cloudkms.googleapis.com/CryptoKey'], | ||||||||||
}; | ||||||||||
|
||||||||||
// define the custom module configuration, update the severity, description, | ||||||||||
// recommendation below | ||||||||||
const customConfig = { | ||||||||||
predicate: expr, | ||||||||||
resourceSelector: resourceSelector, | ||||||||||
severity: Severity.MEDIUM, | ||||||||||
description: 'add your description here', | ||||||||||
recommendation: 'add your recommendation here', | ||||||||||
Comment on lines
+71
to
+72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of placeholder comments, provide a clear explanation of what should be added to the description and recommendation fields. Give examples of good descriptions and recommendations.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @agggaurav2024 this looks like another good suggestion although I'd recommend putting whatever the description and recommendation is for the sample itself. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have taken reference from java code samples |
||||||||||
}; | ||||||||||
|
||||||||||
// define the security health analytics custom module configuration, update the | ||||||||||
// EnablementState below | ||||||||||
const securityHealthAnalyticsCustomModule = { | ||||||||||
name: name, | ||||||||||
displayName: customModuleDisplayName, | ||||||||||
enablementState: EnablementState.ENABLED, | ||||||||||
customConfig: customConfig, | ||||||||||
}; | ||||||||||
|
||||||||||
async function createSecurityHealthAnalyticsCustomModule() { | ||||||||||
const [response] = await client.createSecurityHealthAnalyticsCustomModule({ | ||||||||||
parent: parent, | ||||||||||
securityHealthAnalyticsCustomModule: securityHealthAnalyticsCustomModule, | ||||||||||
}); | ||||||||||
console.log( | ||||||||||
'Security Health Analytics Custom Module creation succeeded: ', | ||||||||||
response | ||||||||||
); | ||||||||||
} | ||||||||||
|
||||||||||
createSecurityHealthAnalyticsCustomModule(); | ||||||||||
// [END securitycenter_create_security_health_analytics_custom_module] | ||||||||||
} | ||||||||||
|
||||||||||
main(...process.argv.slice(2)); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
'use strict'; | ||
|
||
/** | ||
* Retrieve an existing effective security health analytics custom module | ||
*/ | ||
function main(organizationId, customModuleId, locationId = 'global') { | ||
// [START securitycenter_get_effective_security_health_analytics_custom_module] | ||
// npm install '@google-cloud/securitycentermanagement' | ||
const { | ||
SecurityCenterManagementClient, | ||
} = require('@google-cloud/securitycentermanagement'); | ||
|
||
const client = new SecurityCenterManagementClient(); | ||
|
||
/* | ||
* Required. Resource name of security health analytics module. | ||
* Its format is | ||
* `organizations/[organization_id]/locations/[location_id]/effectiveSecurityHealthAnalyticsCustomModules/[custom_module]` | ||
* `folders/[folder_id]/locations/[location_id]/effectiveSecurityHealthAnalyticsCustomModules/[custom_module]` | ||
* `projects/[project_id]/locations/[location_id]/effectiveSecurityHealthAnalyticsCustomModules/[custom_module]` | ||
*/ | ||
const name = `organizations/${organizationId}/locations/${locationId}/effectiveSecurityHealthAnalyticsCustomModules/${customModuleId}`; | ||
|
||
async function getEffectiveSecurityHealthAnalyticsCustomModule() { | ||
const [response] = | ||
await client.getEffectiveSecurityHealthAnalyticsCustomModule({ | ||
name: name, | ||
}); | ||
console.log( | ||
'Security Health Analytics Custom Module get effective succeeded: ', | ||
response | ||
); | ||
} | ||
|
||
getEffectiveSecurityHealthAnalyticsCustomModule(); | ||
// [END securitycenter_get_effective_security_health_analytics_custom_module] | ||
} | ||
|
||
main(...process.argv.slice(2)); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
'use strict'; | ||
|
||
/** | ||
* Retrieve an existing security health analytics custom module | ||
*/ | ||
function main(organizationId, customModuleId, locationId = 'global') { | ||
// [START securitycenter_get_security_health_analytics_custom_module] | ||
// npm install '@google-cloud/securitycentermanagement' | ||
const { | ||
SecurityCenterManagementClient, | ||
} = require('@google-cloud/securitycentermanagement'); | ||
|
||
const client = new SecurityCenterManagementClient(); | ||
|
||
/* | ||
* Required. Resource name of security health analytics module. | ||
* Its format is | ||
* `organizations/[organization_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||
* `folders/[folder_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||
* `projects/[project_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||
*/ | ||
const name = `organizations/${organizationId}/locations/${locationId}/securityHealthAnalyticsCustomModules/${customModuleId}`; | ||
|
||
async function getSecurityHealthAnalyticsCustomModule() { | ||
const [response] = await client.getSecurityHealthAnalyticsCustomModule({ | ||
name: name, | ||
}); | ||
console.log( | ||
'Security Health Analytics Custom Module get succeeded: ', | ||
response | ||
); | ||
} | ||
|
||
getSecurityHealthAnalyticsCustomModule(); | ||
// [END securitycenter_get_security_health_analytics_custom_module] | ||
} | ||
|
||
main(...process.argv.slice(2)); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
'use strict'; | ||
|
||
/** | ||
* Update an existing security health analytics custom module | ||
*/ | ||
function main(organizationId, customModuleId, locationId = 'global') { | ||
// [START securitycenter_update_security_health_analytics_custom_module] | ||
// npm install '@google-cloud/securitycentermanagement' | ||
const { | ||
SecurityCenterManagementClient, | ||
protos, | ||
} = require('@google-cloud/securitycentermanagement'); | ||
|
||
const client = new SecurityCenterManagementClient(); | ||
|
||
const EnablementState = | ||
protos.google.cloud.securitycentermanagement.v1 | ||
.SecurityHealthAnalyticsCustomModule.EnablementState; | ||
|
||
/* | ||
* Required. Resource name of security health analytics module. | ||
* Its format is | ||
* `organizations/[organization_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||
* `folders/[folder_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||
* `projects/[project_id]/locations/[location_id]/securityHealthAnalyticsCustomModules/[custom_module]` | ||
*/ | ||
const name = `organizations/${organizationId}/locations/${locationId}/securityHealthAnalyticsCustomModules/${customModuleId}`; | ||
|
||
// define the security health analytics custom module configuration, update the | ||
// EnablementState below | ||
const securityHealthAnalyticsCustomModule = { | ||
name: name, | ||
enablementState: EnablementState.DISABLED, | ||
}; | ||
|
||
// Set the field mask to specify which properties should be updated. | ||
const fieldMask = { | ||
paths: ['enablement_state'], | ||
}; | ||
|
||
async function updateSecurityHealthAnalyticsCustomModule() { | ||
const [response] = await client.updateSecurityHealthAnalyticsCustomModule({ | ||
updateMask: fieldMask, | ||
securityHealthAnalyticsCustomModule: securityHealthAnalyticsCustomModule, | ||
}); | ||
console.log( | ||
'Security Health Analytics Custom Module update succeeded: ', | ||
response | ||
); | ||
} | ||
|
||
updateSecurityHealthAnalyticsCustomModule(); | ||
// [END securitycenter_update_security_health_analytics_custom_module] | ||
} | ||
|
||
main(...process.argv.slice(2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use duration('30d') instead of '2592000s' for better readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agggaurav2024 what do you think? this seems like a good suggestion to me to make it match what's in the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have taken reference from java code samples
https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/security-command-center/snippets/src/main/java/management/api/CreateSecurityHealthAnalyticsCustomModule.java