Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preserving semver ranges #3539

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Oct 11, 2023

Description

Fixes the following:

  • Updating renovate-bot to preserve semver ranges and update monthly rather than pinning. (Pin dependencies #3522)
  • Current ci lint error see in other PRs is being caused by collision from owlbot + gts fix (credit to: @muncus)

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 11, 2023
@pattishin pattishin mentioned this pull request Oct 11, 2023
1 task
@pattishin pattishin marked this pull request as ready for review October 11, 2023 00:34
@pattishin pattishin requested a review from a team as a code owner October 11, 2023 00:34
@pattishin pattishin mentioned this pull request Nov 16, 2023
1 task
@pattishin pattishin requested a review from a team as a code owner November 17, 2023 04:42
@pattishin pattishin force-pushed the refactor/renovate-preservesemver branch from 86cdf31 to c85faf0 Compare November 17, 2023 05:21
@pattishin pattishin merged commit c76cc84 into main Nov 17, 2023
@pattishin pattishin deleted the refactor/renovate-preservesemver branch November 17, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant