Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl(batch/cpp_application): add a cloud batch example for a cpp application #327

Merged
merged 4 commits into from
May 14, 2024
Merged

impl(batch/cpp_application): add a cloud batch example for a cpp application #327

merged 4 commits into from
May 14, 2024

Conversation

alevenberg
Copy link
Member

No description provided.

@alevenberg alevenberg marked this pull request as ready for review May 14, 2024 02:03
@alevenberg alevenberg requested a review from a team as a code owner May 14, 2024 02:03
coryan
coryan approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this code in and iterate on it, rather than keep nit picking and then merge. Thanks for putting this together.

batch/cpp_application/CMakeLists.txt Outdated Show resolved Hide resolved
batch/cpp_application/README.md Outdated Show resolved Hide resolved
batch/cpp_application/README.md Outdated Show resolved Hide resolved
batch/cpp_application/README.md Show resolved Hide resolved
batch/cpp_application/main.cc Outdated Show resolved Hide resolved
batch/cpp_application/main.cc Outdated Show resolved Hide resolved
batch/cpp_application/main.cc Outdated Show resolved Hide resolved
batch/cpp_application/main.cc Outdated Show resolved Hide resolved
@alevenberg alevenberg enabled auto-merge (squash) May 14, 2024 15:50
@alevenberg alevenberg merged commit c8505e6 into GoogleCloudPlatform:main May 14, 2024
6 checks passed
@alevenberg alevenberg deleted the batch3 branch May 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alevenberg @coryan