Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: pubsub-otel #291

Merged
merged 1 commit into from
Dec 19, 2023
Merged

cleanup: pubsub-otel #291

merged 1 commit into from
Dec 19, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Dec 14, 2023

Move non-obvious types/namespaces into the region of the application used in our docs.

We define GOOGLE_CLOUD_PROJECT=... and GOOGLE_CLOUD_TOPIC=..., so use them as arguments when running the quickstart.

@dbolduc dbolduc requested a review from a team as a code owner December 14, 2023 00:36
@dbolduc dbolduc marked this pull request as draft December 14, 2023 00:36
@dbolduc dbolduc marked this pull request as ready for review December 14, 2023 15:38
@dbolduc dbolduc merged commit 7e0d9d9 into GoogleCloudPlatform:main Dec 19, 2023
6 checks passed
@dbolduc dbolduc deleted the pubsub-tracing-tutorial branch December 19, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevenberg alevenberg alevenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbolduc @alevenberg