-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(pubsub-open-telemetry): add a publisher executable #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is any obligation to provide Bazel files for these examples. If having them makes your life easier, then by all means create them.
ATM I only know how to build the samples with a local version of google-cloud-cpp and bazel. I don't think it's a lot of extra to support both. So leaving both. |
Ack. FWIW:
|
But this will only used the version in vcpkg right? I'm looking for something like |
Yes.
I see. That is possible but waaay too complicated and brittle in CMake. |
This example is not meant for reading consumption (for a user), that is what the quickstart is for. This one is to easily generate traces with different configurations without having to manually change code. I see what you are saying though and I don't think we need the basic tracing example. I will remove it, and just set a default for the arg. |
This reverts commit bbb7129.
Co-authored-by: Carlos O'Ryan <[email protected]>
Co-authored-by: Carlos O'Ryan <[email protected]>
for (auto& id : ids) try { | ||
std::cout << "Sent message with id: " << id.get() << "\n"; | ||
} catch (std::exception const& ex) { | ||
std::cout << "Error in publish: " << ex.what() << "\n"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q. What throws here, and, if it does, what is the state of std::cout
?
Bottom line, it is probably best to separate the throwing and output parts.
No description provided.