feat: add support for public IP #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
requested review from
cthumuluru,
nancynh and
a team
as code owners
jackwotherspoon
changed the title
enocom
approved these changes
Jan 18, 2024
| @@ -227,3 +227,40 @@ func TestAutoIAMAuthN(t *testing.T) { | |||
| } | |||
| t.Log(tt) | |||
| } | |||
|
|
|||
| func TestPublicIP(t *testing.T) { | |||
There was a problem hiding this comment.
Shall we put region tags around this usage so we can get it into the public docs?
There was a problem hiding this comment.
Do we want to do that as a follow-up PR and arrange both Connector Public IP and Connector Auto IAM AuthN like our direct path tests?
There was a problem hiding this comment.
Because we don't currently have region tags around Connector Auto IAM AuthN...
enocom
added
the
do not merge
enocom
force-pushed
the
public-ip-support
branch
from
b19b964 to
38d3237
Compare
enocom
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Public IP connections to AlloyDB instances via Go Connector. Default option for
ipTypewill be Private IP but users wishing to use Public IP can use the newWithPublicIP()DialOption.PR Checklist:
ipAddrto be returned