Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconnection error messages #188

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Jan 10, 2025

When reconnecting the ComboBox Chooser, Split Button Chooser, and a widget dragging in (conditionally) would throw error messages

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (d43edfd) to head (6c7e709).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   75.97%   75.94%   -0.04%     
==========================================
  Files          80       80              
  Lines        8551     8555       +4     
==========================================
  Hits         6497     6497              
- Misses       2054     2058       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 2a6d323 into main Jan 10, 2025
9 checks passed
@Gold872 Gold872 deleted the fix-reconnection-error-messages branch January 10, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant