Add support for ioctl VIDIOC_S_CTRL #13
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
I've largely used the other files in the
ioctl
as a template for this, rather than fully understanding the inner workings of your library. Does this look reasonable for an implementation of the above ioctl function call?Of note, and it should probably be in a separate pull request, but I've made
Encoder.device
public. The purpose of this is to act as an escape hatch when using theEncoder
api to drop down to the lower levelioctl
. I'm not experienced withArc<_>
, so I don't know if it's more appropriate to make a separate method that looks more like this pseudocode: