Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ioctl VIDIOC_S_CTRL #13

Closed
wants to merge 2 commits into from
Closed

Add support for ioctl VIDIOC_S_CTRL #13

wants to merge 2 commits into from

Conversation

mfreeborn
Copy link

Closes #12

I've largely used the other files in the ioctl as a template for this, rather than fully understanding the inner workings of your library. Does this look reasonable for an implementation of the above ioctl function call?

Of note, and it should probably be in a separate pull request, but I've made Encoder.device public. The purpose of this is to act as an escape hatch when using the Encoder api to drop down to the lower level ioctl. I'm not experienced with Arc<_>, so I don't know if it's more appropriate to make a separate method that looks more like this pseudocode:

pub fn device(&self) -> Arc<Device> {
    Arc::clone(self.device)
}

@Gnurou
Copy link
Owner

Gnurou commented Feb 2, 2023

Hi! Sorry for taking so long to come back to this. PR #14 adds support for S_EXT_CTRL and requests, could you take a look and check if this fits your needs as well?

@mfreeborn
Copy link
Author

Yes, let's close this in favour of #14 for now.

@mfreeborn mfreeborn closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for VIDIOC_S_CTRL?
2 participants