Write migration file to add missed optimism donations to db #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminlatifi
requested changes
Dec 24, 2023
There was a problem hiding this comment.
This donation is missed 0x8838d5be728ac29110340aacd883e9ede19048146e1c28842e4f4e28e4ba4761
| }, | ||
|
|
||
| // https://optimistic.etherscan.io/tx/0x8838d5be728ac29110340aacd883e9ede19048146e1c28842e4f4e28e4ba4761 | ||
| { |
There was a problem hiding this comment.
@aminlatifi I added the missed dontion here
aminlatifi
requested changes
Dec 24, 2023
Comment on lines
238
to
239
| await refreshProjectEstimatedMatchingView(); | ||
| await refreshProjectDonationSummaryView(); |
There was a problem hiding this comment.
These two can be done out of loop and only once
There was a problem hiding this comment.
Thanks @aminlatifi , you are right, I moved it to out of the function
|
The data is correct now, thanks @mohammadranjbarz |
aminlatifi
approved these changes
Dec 24, 2023
@CarlosQ96 Would you please carefully check the donation saving part and be sure everything is following the procedure? |
CarlosQ96
approved these changes
Dec 26, 2023
mohammadranjbarz
deleted the
hotfix_3520_add_missed_optimism_donations
branch
aminlatifi
added a commit
that referenced
this pull request
Dec 28, 2023
* disable ratelimiter from env (#1208) * Write migration file to add missed optimism donations to db (#1213) * Write migration file to add missed optimism donations to db related to https://github.com/Giveth/giveth-dapps-v2/issues/3520 * Add another missed donation, make addresses lowercase before put in DB * Move updating views functions out of the loop * add missing optimism donation --------- Co-authored-by: Carlos <[email protected]> * Update master-pipeline.yml * disable dapp cors with envs * Renamed variable --------- Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: mohammadranjbarz <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: Moe Shehab <[email protected]>
mohammadranjbarz
added a commit
that referenced
this pull request
Jan 1, 2024
* Comment one test case * Added fill snapshot round number back * Removed blockNumber from snapshot in tests * Fixed migrations to be compatible with removing blockNumber from history * add project status to getVerificationFormByProjectId query * Add sent matching fund to total donations of project and total received of users related to Giveth/giveth-dapps-v2#3386 * Fix test case for adding matching fund to toal donation amount of projects * Implement qfRoundStats webservice related to Giveth/giveth-dapps-v2#3250 * Change allProjects webservice to support qfRoundSlug related to Giveth/giveth-dapps-v2#3250 * Fix test cases to create qfRound * Fix test cases to create qfRound * Fix test cases to create qfRound * Fix test cases to create qfRound * Fix updateProjectWithVerificationForm * Revert updateUserTotalReceived() funciton * Fix updateUserTotalReceived() test case * Fix updateUserTotalReceived() test case * Fix mordor testnet node url * Read node rpc urls from process.env instead of config * Add log * Fix etc provider url in github actions config * Fix AddSlugToQfRound migration * Remove unused tests * add safeTransaction to donation logic * fix uniqueness index on donation table * comment a network tests * fix nullability of transactionId * make nonce nullable for safe donations * add nullability to nonce in createdonationResolver * remove undefined clause from joi validations * Fix insertDonationsFromQfRoundHistory when can not find corosponding address * Call refreshProjectDonationSummaryView() immediately after insertDonationsFromQfRoundHistory) * Save non-evm user wallet address capitalization * Updated the authentication service related address in test.env * updated auth server in test env * add validations for multisig donations * add abis decoder for multisig transactions and parsers * fetch from and to addresses correctly for multisig validations * fix native token transfer for multisig transactions * fix transaction amount in tests for multisig * fix fromAddress edgecase for multisig * make params options for transactionData * Project Solana Address Support (#1200) * Initial add solana address support to project address * Added chaintype to graphql validator and project verification form * Added chainType to token Refactored project filter query builder Added tests * Fixed issue in test graphql query Added some tests * Fixed issues with tests * Revert unwanted changes happend after merge * Fixed issues happend after merge * Fixed an issue in setting chainType in projectUpdate * Revert "Removed snapshot block number" (#1202) * comment uniqueness migration constraint (#1203) * graphql allow null for transactionId (#1205) * Create Solana Donations Integration (#1204) * modify create donation resolver to handle solana token * fix backward compatible tests * add tests to solana donation creation * add tests for solana resolvers (wip) * fix solana donation tests and logic * handle multiple solana tokens (future) * fix some qfround tests * add solana native token migration * Update test/testUtils.ts solana token address Co-authored-by: Amin Latifi <[email protected]> * Update migration/data/seedTokens.ts Decimals in Token Co-authored-by: Amin Latifi <[email protected]> * Update migration/data/seedTokens.ts Co-authored-by: Amin Latifi <[email protected]> * Update src/resolvers/donationResolver.test.ts Co-authored-by: Amin Latifi <[email protected]> * solana feedback * fix seed tokens * fix solana donation flow and apply code feedback * remove unnecesary code and improve migration --------- Co-authored-by: Amin Latifi <[email protected]> * disable ratelimiter from env (#1212) Co-authored-by: Carlos <[email protected]> * Hotfix/solana project address (#1210) * Changed address invalid message * Removed unused queries * Fixed solana address verification problem * Update master-pipeline.yml * Verify Solana transactions (#1209) * Add test cases for verifying solana transactions related to #1171 * Fix build problems * Refactor verifying solana transfer transactions * Add disable cors and rate limiting to staging (#1221) * disable ratelimiter from env (#1208) * Write migration file to add missed optimism donations to db (#1213) * Write migration file to add missed optimism donations to db related to https://github.com/Giveth/giveth-dapps-v2/issues/3520 * Add another missed donation, make addresses lowercase before put in DB * Move updating views functions out of the loop * add missing optimism donation --------- Co-authored-by: Carlos <[email protected]> * Update master-pipeline.yml * disable dapp cors with envs * Renamed variable --------- Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: mohammadranjbarz <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: Moe Shehab <[email protected]> * Add test and regex for solana token addresses (#1224) * add test and regex for solana token addresses * Upated solana wallet address and programId regex --------- Co-authored-by: Amin Latifi <[email protected]> * Hotfix solana transction id validator (#1225) * Improved solana transction id match regex * Update solana transaction id regex --------- Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: Amin Latifi <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: Krati Jain <[email protected]> Co-authored-by: Mateo Daza <[email protected]> Co-authored-by: Moe Shehab <[email protected]>
aminlatifi
added a commit
that referenced
this pull request
Jan 11, 2024
* Multi sig release, 2023-12-31 (#1227) * Comment one test case * Added fill snapshot round number back * Removed blockNumber from snapshot in tests * Fixed migrations to be compatible with removing blockNumber from history * add project status to getVerificationFormByProjectId query * Add sent matching fund to total donations of project and total received of users related to Giveth/giveth-dapps-v2#3386 * Fix test case for adding matching fund to toal donation amount of projects * Implement qfRoundStats webservice related to Giveth/giveth-dapps-v2#3250 * Change allProjects webservice to support qfRoundSlug related to Giveth/giveth-dapps-v2#3250 * Fix test cases to create qfRound * Fix test cases to create qfRound * Fix test cases to create qfRound * Fix test cases to create qfRound * Fix updateProjectWithVerificationForm * Revert updateUserTotalReceived() funciton * Fix updateUserTotalReceived() test case * Fix updateUserTotalReceived() test case * Fix mordor testnet node url * Read node rpc urls from process.env instead of config * Add log * Fix etc provider url in github actions config * Fix AddSlugToQfRound migration * Remove unused tests * add safeTransaction to donation logic * fix uniqueness index on donation table * comment a network tests * fix nullability of transactionId * make nonce nullable for safe donations * add nullability to nonce in createdonationResolver * remove undefined clause from joi validations * Fix insertDonationsFromQfRoundHistory when can not find corosponding address * Call refreshProjectDonationSummaryView() immediately after insertDonationsFromQfRoundHistory) * Save non-evm user wallet address capitalization * Updated the authentication service related address in test.env * updated auth server in test env * add validations for multisig donations * add abis decoder for multisig transactions and parsers * fetch from and to addresses correctly for multisig validations * fix native token transfer for multisig transactions * fix transaction amount in tests for multisig * fix fromAddress edgecase for multisig * make params options for transactionData * Project Solana Address Support (#1200) * Initial add solana address support to project address * Added chaintype to graphql validator and project verification form * Added chainType to token Refactored project filter query builder Added tests * Fixed issue in test graphql query Added some tests * Fixed issues with tests * Revert unwanted changes happend after merge * Fixed issues happend after merge * Fixed an issue in setting chainType in projectUpdate * Revert "Removed snapshot block number" (#1202) * comment uniqueness migration constraint (#1203) * graphql allow null for transactionId (#1205) * Create Solana Donations Integration (#1204) * modify create donation resolver to handle solana token * fix backward compatible tests * add tests to solana donation creation * add tests for solana resolvers (wip) * fix solana donation tests and logic * handle multiple solana tokens (future) * fix some qfround tests * add solana native token migration * Update test/testUtils.ts solana token address Co-authored-by: Amin Latifi <[email protected]> * Update migration/data/seedTokens.ts Decimals in Token Co-authored-by: Amin Latifi <[email protected]> * Update migration/data/seedTokens.ts Co-authored-by: Amin Latifi <[email protected]> * Update src/resolvers/donationResolver.test.ts Co-authored-by: Amin Latifi <[email protected]> * solana feedback * fix seed tokens * fix solana donation flow and apply code feedback * remove unnecesary code and improve migration --------- Co-authored-by: Amin Latifi <[email protected]> * disable ratelimiter from env (#1212) Co-authored-by: Carlos <[email protected]> * Hotfix/solana project address (#1210) * Changed address invalid message * Removed unused queries * Fixed solana address verification problem * Update master-pipeline.yml * Verify Solana transactions (#1209) * Add test cases for verifying solana transactions related to #1171 * Fix build problems * Refactor verifying solana transfer transactions * Add disable cors and rate limiting to staging (#1221) * disable ratelimiter from env (#1208) * Write migration file to add missed optimism donations to db (#1213) * Write migration file to add missed optimism donations to db related to https://github.com/Giveth/giveth-dapps-v2/issues/3520 * Add another missed donation, make addresses lowercase before put in DB * Move updating views functions out of the loop * add missing optimism donation --------- Co-authored-by: Carlos <[email protected]> * Update master-pipeline.yml * disable dapp cors with envs * Renamed variable --------- Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: mohammadranjbarz <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: Moe Shehab <[email protected]> * Add test and regex for solana token addresses (#1224) * add test and regex for solana token addresses * Upated solana wallet address and programId regex --------- Co-authored-by: Amin Latifi <[email protected]> * Hotfix solana transction id validator (#1225) * Improved solana transction id match regex * Update solana transaction id regex --------- Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: Amin Latifi <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: Krati Jain <[email protected]> Co-authored-by: Mateo Daza <[email protected]> Co-authored-by: Moe Shehab <[email protected]> * add isactive and fix adminjs for categories (#1223) (#1234) --------- Co-authored-by: mohammadranjbarz <[email protected]> Co-authored-by: CarlosQ96 <[email protected]> Co-authored-by: Carlos <[email protected]> Co-authored-by: Krati Jain <[email protected]> Co-authored-by: Mateo Daza <[email protected]> Co-authored-by: Moe Shehab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the missed donations that mentioned in #1233 to DB