fix donate button for deactive projects

[maryjaf]

#5008

Summary by CodeRabbit

• New Features
  • Donation views now display a clear warning when a project is not active.
  • Interactive elements, such as donation buttons and links, are conditionally disabled to prevent actions when donations aren’t allowed.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 2, 2025 10:20am

[coderabbitai]

Walkthrough

The changes introduce a new constant isActive to verify a project’s active status and modify donation-related UI behavior. In the Recurring Donation Card component, a warning message is rendered and the donation button is disabled when the project is not active. In the Project Public Actions component, the donation link’s destination, click behavior, and pointer events are conditionally modified based on the project’s active state. An import for EProjectStatus is also added to support these status checks.

Changes

File(s)	Change Summary
src/…/RecurringDonationCard.tsx, src/…/ProjectPublicActions.tsx	Introduced the isActive constant (using EProjectStatus) to control donation components. In RecurringDonationCard, a warning message is displayed and the ActionButton is disabled when inactive. In ProjectPublicActions, the donation link’s href, onClick, and pointer events are updated based on the active status.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant RDC as RecurringDonationCard
  participant AB as ActionButton

  U->>RDC: Open donation card
  RDC->>RDC: Check project status (isActive)
  alt Project is Active
    RDC->>AB: Enable donation button
  else Project is Inactive
    RDC->>RDC: Render warning message
    RDC->>AB: Disable donation button
  end

Loading

sequenceDiagram
  participant U as User
  participant PPA as ProjectPublicActions
  participant L as DonationLink

  U->>PPA: Click donation link
  PPA->>PPA: Check project status (isActive)
  alt Project is Active
    PPA->>L: Set href to donation page
    L-->>U: Navigate to donation page
  else Project is Inactive
    PPA->>L: Disable link behavior (prevent default, pointerEvents disabled)
  end

Loading

Possibly related PRs

• Projects with $0 in qf round matching show matching funds coming soon #4828: Introduces the isActive constant to manage UI state for donation components, paralleling the current modifications.
• Feat/Improve back button on donation page #4971: Utilizes isActive to control rendering logic in donation-related interfaces, closely aligning with these changes.
• Simplify estimated matching #5038: Focuses on UI control based on project status using the isActive variable, directly related to the updates in donation functionalities.

Suggested labels

Code Review

Suggested reviewers

• kkatusic
• CarlosQ96

Poem

I'm a bunny coding in delight,
Hopping through changes with all my might.
isActive guides the flow, so clear,
Disabling links when projects aren't near.
With a twitch of my nose and a joyful beat,
I celebrate each fix with a binky and a treat!
Hop on, dear coder, the future's sweet!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d59e68b and a0f428b.

📒 Files selected for processing (2)

• src/components/views/donate/Recurring/RecurringDonationCard.tsx (3 hunks)
• src/components/views/project/projectActionCard/ProjectPublicActions.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (5)

src/components/views/donate/Recurring/RecurringDonationCard.tsx (4)

26-26: Good addition of the EProjectStatus import.

The import of EProjectStatus is necessary to properly check the project's active status.

---

101-101: Well-defined project active status check.

The isActive constant properly checks if the project's status is ACTIVE using optional chaining, which handles cases where project.status might be undefined.

---

753-768: Good implementation of warning for inactive projects.

The warning message is appropriately displayed when a project is not active, providing clear feedback to users. The styling is consistent with the application's design language, and the message is properly internationalized.

---

772-772: Properly disabled donate button for inactive projects.

The button is correctly disabled when the project is not active, preventing donations to inactive projects. This is consistent with the warning message displayed above.

src/components/views/project/projectActionCard/ProjectPublicActions.tsx (1)

133-138: Good implementation of donate link behavior for inactive projects.

The changes effectively prevent users from donating to inactive projects by:

1. Changing the href to '#' when the project is not active
2. Preventing the default navigation behavior with onClick
3. Disabling pointer events visually

This creates a consistent user experience that aligns with the changes in the RecurringDonationCard component.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kkatusic]

LGTM, thx @LatifatAbdullahi