p2p/nat: skip TestUPNP in non-CI environments if discover fails (ethe…

…reum#22877) Fixes ethereum#21476
Gitwind · May 25, 2021 · 750115f · 750115f
1 parent 51b32cc
commit 750115f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/p2p/nat/natupnp_test.go b/p2p/nat/natupnp_test.go
@@ -21,6 +21,7 @@ import (
 	"io"
 	"net"
 	"net/http"
+	"os"
 	"runtime"
 	"strings"
 	"testing"
@@ -162,7 +163,11 @@ func TestUPNP_DDWRT(t *testing.T) {
 	// Attempt to discover the fake device.
 	discovered := discoverUPnP()
 	if discovered == nil {
-		t.Fatalf("not discovered")
+		if os.Getenv("CI") != "" {
+			t.Fatalf("not discovered")
+		} else {
+			t.Skipf("UPnP not discovered (known issue, see https://github.com/ethereum/go-ethereum/issues/21476)")
+		}
 	}
 	upnp, _ := discovered.(*upnp)
 	if upnp.service != "IGDv1-IP1" {