Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 4xx error instead of 5xx when failed to extract access token #397

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

taranvohra
Copy link
Member

otherwise it adds noise to our alerts. the failure could happen for reasons like invalid code etc. we should not consider them as server errors

Copy link

changeset-bot bot commented Feb 9, 2024

🦋 Changeset detected

Latest commit: f224923

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@gitbook/runtime Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taranvohra taranvohra merged commit 1e3c023 into main Feb 9, 2024
2 checks passed
@taranvohra taranvohra deleted the fix-oauth-error-runtime branch February 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant