-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.14] Update MergeRequests::all
to use millisecond precision
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2023-01-24T18:05:25.801Z works - 2023-01-24T18:05:25.801+00:00 does not work
Adjusted the formatting:
|
This uses millisecond precision, not microsecond? |
janedbal
changed the title
MergeRequests::all: send datetimes with microsecond precision
MergeRequests::all: send datetimes with millisecond precision
Dec 14, 2023
Yes, adjusted title. GitLab API returns datetimes with milliseconds, not micro. So that is probably the best precision we can use. |
@GrahamCampbell any needed changes here? |
ping |
GrahamCampbell
changed the title
MergeRequests::all: send datetimes with millisecond precision
[11.14] Update Mar 17, 2024
MergeRequests::all
to use millisecond precision
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are iteratively fetching new MRs via:
And there is more than 100 MR updated within a second. Current implementation causes the same MRs to be analysed again every time. But the API seems to support microsecond precision, so this should fix it.