Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sca,iac): remove code #136

Merged
merged 1 commit into from
Feb 6, 2025
Merged

chore(sca,iac): remove code #136

merged 1 commit into from
Feb 6, 2025

Conversation

FlorianPerucki
Copy link

Remove unused code related to SCA and IaC

@FlorianPerucki FlorianPerucki requested a review from a team as a code owner February 5, 2025 10:30
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.73%. Comparing base (6cba0a2) to head (04aa977).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   93.99%   95.73%   +1.74%     
==========================================
  Files           7        5       -2     
  Lines        1382     1196     -186     
==========================================
- Hits         1299     1145     -154     
+ Misses         83       51      -32     
Flag Coverage Δ
unittests 95.73% <ø> (+1.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FlorianPerucki FlorianPerucki force-pushed the fperucki/remove-sca-iac branch from 1874cf6 to e62f72b Compare February 5, 2025 10:34
@FlorianPerucki FlorianPerucki force-pushed the fperucki/remove-sca-iac branch from e62f72b to 04aa977 Compare February 5, 2025 10:34
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much red :)

Looks good 👍.

@agateau-gg agateau-gg merged commit 445f190 into master Feb 6, 2025
19 checks passed
@agateau-gg agateau-gg deleted the fperucki/remove-sca-iac branch February 6, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants