[GSK-2569, GSK-2585, GSK-2658] Scan for computer vision #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabah-khalek
suggested changes
Jan 17, 2024
There was a problem hiding this comment.
First very fast skim-through:
- I think you pushed
giskard_vision/scanner/scanner_vision.pyby mistake? - Could you create a new module called
detectorsundergiskard_visionand put every detector in a separate script? - Make the example a notebook, and just call the detectors from the module.
I'll review the logic inside the detectors after our meeting.
…ision into GSK-2569-report-gen
…ire a compute_results method that outputs a list of dictionaries with specific format that corresponds to issues
[GSK-2569] Detectors structure
…ision into GSK-2569-report-gen
rabah-khalek
suggested changes
Jan 29, 2024
There was a problem hiding this comment.
Overall good, could you please also create a scan API similar to this https://github.com/Giskard-AI/giskard/blob/da017987fa74f89e4f48945907a8febcb8cb3dd4/giskard/scanner/__init__.py#L26?
rabah-khalek
suggested changes
Jan 29, 2024
rabah-khalek
suggested changes
Jan 30, 2024
removed detectors from giskard_vision init
rabah-khalek
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add report generation for computer vision tasks based on Giskard
Scannerobject. The user can define a list ofDetectorobjects to create tests by himself and generate the report with aScanner.An example is provided in
examples/landmark_detection/examples.py