Skip to content

Commit

Permalink
Correct CreateChannel and QueryMembers test (#102)
Browse files Browse the repository at this point in the history
  • Loading branch information
ferhatelmas authored Oct 12, 2020
1 parent 62bb225 commit 6e4e2ba
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions channel.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,10 @@ func (c *Client) CreateChannel(chanType, chanID, userID string, data map[string]

data["created_by"] = map[string]string{"id": userID}

err := ch.query(options, data)

return ch, err
if err := ch.query(options, data); err != nil {
return nil, err
}
return ch, nil
}

type SendFileRequest struct {
Expand Down
8 changes: 4 additions & 4 deletions channel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ func TestClient_CreateChannel(t *testing.T) {
assert.Equal(t, c, got.client, "client link")
assert.Equal(t, ch.Type, got.Type, "channel type")
assert.Equal(t, ch.ID, got.ID, "channel id")
assert.Equal(t, got.MemberCount, ch.MemberCount, "member count")
assert.Len(t, got.Members, got.MemberCount, "members length")
assert.Equal(t, ch.MemberCount, got.MemberCount, "member count")
assert.Len(t, got.Members, ch.MemberCount, "members length")
})

tests := []struct {
Expand Down Expand Up @@ -162,8 +162,8 @@ func TestChannel_QueryMembers(t *testing.T) {

require.NoError(t, err)
require.Len(t, members, 2)
require.Equal(t, prefix+"jessica", members[0].UserID)
require.Equal(t, prefix+"john2", members[1].UserID)
require.Equal(t, prefix+"jessica", members[0].User.ID)
require.Equal(t, prefix+"john2", members[1].User.ID)
}

// See https://getstream.io/chat/docs/channel_members/ for more details.
Expand Down

0 comments on commit 6e4e2ba

Please sign in to comment.